fix(agents): sweep stale CLI image files

obviyus · obviyus · commit 569e75fc3dfe · 2026-07-02T09:10:04.000-07:00
Fixes #98946
diff --git a/src/agents/cli-runner.helpers.test.ts b/src/agents/cli-runner.helpers.test.ts
@@ -287,6 +287,42 @@ describe("writeCliImages", () => {
     }
   });
 
+  it("sweeps stale workspace-scoped CLI image files", async () => {
+    const workspaceDir = await fs.mkdtemp(
+      path.join(resolvePreferredOpenClawTmpDir(), "openclaw-cli-write-sweep-"),
+    );
+    const imageRoot = path.join(workspaceDir, ".openclaw-cli-images");
+    const stalePath = path.join(imageRoot, "stale.png");
+    const freshPath = path.join(imageRoot, "fresh.png");
+    const image: ImageContent = {
+      type: "image",
+      data: "bmV3LWltYWdl",
+      mimeType: "image/png",
+    };
+
+    await fs.mkdir(imageRoot, { recursive: true });
+    await fs.writeFile(stalePath, "stale");
+    await fs.writeFile(freshPath, "fresh");
+    const staleTime = new Date(Date.now() - 8 * 24 * 60 * 60 * 1_000);
+    await fs.utimes(stalePath, staleTime, staleTime);
+
+    const written = await writeCliImages({
+      backend: { command: "gemini", imagePathScope: "workspace" },
+      workspaceDir,
+      images: [image],
+    });
+
+    try {
+      await expect(fs.access(stalePath)).rejects.toMatchObject({ code: "ENOENT" });
+      await expect(fs.readFile(freshPath, "utf-8")).resolves.toBe("fresh");
+      await expect(fs.readFile(written.paths[0])).resolves.toEqual(
+        Buffer.from(image.data, "base64"),
+      );
+    } finally {
+      await fs.rm(workspaceDir, { recursive: true, force: true });
+    }
+  });
+
   it("hydrates prompt media refs into codex image args through the helper seams", async () => {
     const tempDir = await fs.mkdtemp(
       path.join(resolvePreferredOpenClawTmpDir(), "openclaw-cli-prompt-image-"),
diff --git a/src/agents/cli-runner/helpers.ts b/src/agents/cli-runner/helpers.ts
@@ -36,6 +36,7 @@ import { buildConfiguredAgentSystemPrompt } from "../system-prompt-config.js";
 import { buildSystemPromptParams } from "../system-prompt-params.js";
 import type { SilentReplyPromptMode } from "../system-prompt.types.js";
 import { sanitizeImageBlocks } from "../tool-images.js";
+import { cliBackendLog } from "./log.js";
 import { formatTomlConfigOverride } from "./toml-inline.js";
 /** Re-export CLI reliability helpers used by older runner call sites. */
 export {
@@ -45,6 +46,8 @@ export {
 } from "./reliability.js";
 
 const CLI_RUN_QUEUE = new KeyedAsyncQueue();
+const CLI_IMAGE_SWEEP_TTL_MS = 7 * 24 * 60 * 60 * 1_000;
+const sweptCliImageRoots = new Set<string>();
 
 function isClaudeCliProvider(providerId: string): boolean {
   return normalizeOptionalLowercaseString(providerId) === "claude-cli";
@@ -295,6 +298,53 @@ function resolveCliImageRoot(params: { backend: CliBackendConfig; workspaceDir:
   return path.join(resolvePreferredOpenClawTmpDir(), "openclaw-cli-images");
 }
 
+function isFileNotFoundError(error: unknown): boolean {
+  return Boolean(
+    error &&
+    typeof error === "object" &&
+    "code" in error &&
+    (error as { code?: unknown }).code === "ENOENT",
+  );
+}
+
+async function sweepCliImageRoot(imageRoot: string): Promise<void> {
+  if (sweptCliImageRoots.has(imageRoot)) {
+    return;
+  }
+  sweptCliImageRoots.add(imageRoot);
+  try {
+    const cutoffMs = Date.now() - CLI_IMAGE_SWEEP_TTL_MS;
+    const entries = await fs.readdir(imageRoot, { withFileTypes: true });
+    for (const entry of entries) {
+      if (!entry.isFile()) {
+        continue;
+      }
+      const entryPath = path.join(imageRoot, entry.name);
+      const stat = await fs.stat(entryPath).catch((error: unknown) => {
+        if (isFileNotFoundError(error)) {
+          return undefined;
+        }
+        throw error;
+      });
+      if (!stat) {
+        continue;
+      }
+      if (stat.mtimeMs >= cutoffMs) {
+        continue;
+      }
+      try {
+        await fs.rm(entryPath, { force: true });
+      } catch (error) {
+        if (!isFileNotFoundError(error)) {
+          throw error;
+        }
+      }
+    }
+  } catch (error) {
+    cliBackendLog.debug(`cli image cache sweep failed: ${String(error)}`);
+  }
+}
+
 function appendImagePathsToPrompt(prompt: string, paths: string[], prefix = ""): string {
   if (!paths.length) {
     return prompt;
@@ -353,6 +403,7 @@ export async function writeCliImages(params: {
     workspaceDir: params.workspaceDir,
   });
   await fs.mkdir(imageRoot, { recursive: true, mode: 0o700 });
+  await sweepCliImageRoot(imageRoot);
   const store = privateFileStore(imageRoot);
   const paths: string[] = [];
   for (const image of params.images) {
