fix(synology-chat): respect SYNOLOGY_RATE_LIMIT=0 in env var parsing

scoootscooob · claude · scoootscooob · commit 5629a3ddacda · 2026-03-07T13:28:46.000-08:00
parseInt(envRateLimit, 10) || 30 drops valid 0 because 0 is falsy. Switch to ?? (nullish coalescing) so only NaN triggers the default. Fixes #39191 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
diff --git a/extensions/synology-chat/src/accounts.test.ts b/extensions/synology-chat/src/accounts.test.ts
@@ -130,4 +130,11 @@ describe("resolveAccount", () => {
     const account = resolveAccount(cfg);
     expect(account.allowedUserIds).toEqual(["u1", "u2"]);
   });
+
+  it("respects SYNOLOGY_RATE_LIMIT=0 instead of defaulting to 30", () => {
+    process.env.SYNOLOGY_RATE_LIMIT = "0";
+    const cfg = { channels: { "synology-chat": {} } };
+    const account = resolveAccount(cfg);
+    expect(account.rateLimitPerMinute).toBe(0);
+  });
 });
diff --git a/extensions/synology-chat/src/accounts.ts b/extensions/synology-chat/src/accounts.ts
@@ -63,6 +63,8 @@ export function resolveAccount(cfg: any, accountId?: string | null): ResolvedSyn
   const envNasHost = process.env.SYNOLOGY_NAS_HOST ?? "localhost";
   const envAllowedUserIds = process.env.SYNOLOGY_ALLOWED_USER_IDS ?? "";
   const envRateLimit = process.env.SYNOLOGY_RATE_LIMIT;
+  const parsedRateLimit = envRateLimit != null ? parseInt(envRateLimit, 10) : NaN;
+  const envRateLimitValue = Number.isFinite(parsedRateLimit) ? parsedRateLimit : 30;
   const envBotName = process.env.OPENCLAW_BOT_NAME ?? "OpenClaw";
 
   // Merge: account override > base channel config > env var
@@ -78,9 +80,7 @@ export function resolveAccount(cfg: any, accountId?: string | null): ResolvedSyn
       accountOverride.allowedUserIds ?? channelCfg.allowedUserIds ?? envAllowedUserIds,
     ),
     rateLimitPerMinute:
-      accountOverride.rateLimitPerMinute ??
-      channelCfg.rateLimitPerMinute ??
-      (envRateLimit ? parseInt(envRateLimit, 10) || 30 : 30),
+      accountOverride.rateLimitPerMinute ?? channelCfg.rateLimitPerMinute ?? envRateLimitValue,
     botName: accountOverride.botName ?? channelCfg.botName ?? envBotName,
     allowInsecureSsl: accountOverride.allowInsecureSsl ?? channelCfg.allowInsecureSsl ?? false,
   };
