fix(qa): reject duplicate gauntlet selectors

vincentkoc · vincentkoc · commit 52251261ca0f · 2026-06-23T15:32:12.000+02:00
diff --git a/scripts/check-plugin-gateway-gauntlet.mjs b/scripts/check-plugin-gateway-gauntlet.mjs
@@ -190,6 +190,8 @@ export function parseArgs(argv) {
   if (options.qaScenarios.length === 0) {
     options.qaScenarios = [...DEFAULT_QA_SCENARIOS];
   }
+  assertNoDuplicateValues(options.pluginIds, "--plugin");
+  assertNoDuplicateValues(options.qaScenarios, "--qa-scenario");
   return options;
 }
 
@@ -244,6 +246,20 @@ function normalizeCsv(raw) {
     : [];
 }
 
+function assertNoDuplicateValues(values, label) {
+  const seen = new Set();
+  for (const value of values) {
+    const normalized = value.trim();
+    if (!normalized) {
+      continue;
+    }
+    if (seen.has(normalized)) {
+      throw new Error(`Duplicate ${label} value: ${normalized}`);
+    }
+    seen.add(normalized);
+  }
+}
+
 function readOptionalPositiveIntEnv(name) {
   const raw = process.env[name];
   return raw ? parsePositiveInt(raw, name) : undefined;
diff --git a/test/scripts/plugin-gateway-gauntlet.test.ts b/test/scripts/plugin-gateway-gauntlet.test.ts
@@ -131,6 +131,25 @@ describe("plugin gateway gauntlet helpers", () => {
     });
   });
 
+  it("rejects duplicate repeatable selectors", () => {
+    expect(() => parseArgs(["--plugin", "telegram", "--plugin", "telegram"])).toThrow(
+      "Duplicate --plugin value: telegram",
+    );
+    expect(() =>
+      parseArgs([
+        "--qa-scenario",
+        "channel-chat-baseline",
+        "--qa-scenario",
+        "channel-chat-baseline",
+      ]),
+    ).toThrow("Duplicate --qa-scenario value: channel-chat-baseline");
+
+    vi.stubEnv("OPENCLAW_PLUGIN_GATEWAY_GAUNTLET_IDS", "telegram,discord");
+    expect(() => parseArgs(["--plugin", "telegram"])).toThrow(
+      "Duplicate --plugin value: telegram",
+    );
+  });
+
   it("rejects valued flags followed by another option", () => {
     for (const flag of [
       "--repo-root",
