fix(embeddings): preserve provider alias cache identity

vincentkoc · vincentkoc · commit 50429157e38d · 2026-07-11T16:22:22.000+08:00
diff --git a/src/plugins/openai-compatible-embedding-provider.test.ts b/src/plugins/openai-compatible-embedding-provider.test.ts
@@ -330,9 +330,18 @@ describe("openai-compatible generic embedding provider", () => {
     };
     options.acquireLocalService = acquireLocalService;
 
-    const { provider } = await createOpenAICompatibleEmbeddingProvider(options);
+    const result = await openAICompatibleEmbeddingProviderAdapter.create(options);
+    const provider = result.provider;
+    if (!provider) {
+      throw new Error("expected openai-compatible provider");
+    }
     await expect(provider.embed("hello")).resolves.toEqual([0.1, 0.2, 0.3]);
 
+    expect(result.runtime?.cacheKeyData).toMatchObject({
+      provider: "gpu-spark",
+      baseUrl: server.baseUrl,
+      model: "nomic-embed-text",
+    });
     expect(acquireLocalService).toHaveBeenCalledWith(
       {
         providerId: "gpu-spark",
diff --git a/src/plugins/openai-compatible-embedding-provider.ts b/src/plugins/openai-compatible-embedding-provider.ts
@@ -29,6 +29,7 @@ const EMBEDDING_ERROR_TRUNCATED_SUFFIX = "... [truncated]";
 
 /** Normalized OpenAI-compatible embedding client configuration. */
 export type OpenAICompatibleEmbeddingClient = {
+  providerId: string;
   baseUrl: string;
   headers: Record<string, string>;
   ssrfPolicy?: SsrFPolicy;
@@ -392,6 +393,10 @@ async function createOpenAICompatibleEmbeddingClient(
 ): Promise<OpenAICompatibleEmbeddingClient> {
   const resolvedProvider = resolveConfiguredProvider(options);
   const configuredProvider = resolvedProvider?.config;
+  const providerId =
+    resolvedProvider?.providerId ??
+    options.provider?.trim() ??
+    OPENAI_COMPATIBLE_EMBEDDING_PROVIDER_ID;
   const remoteBaseUrl = normalizeOptionalString(options.remote?.baseUrl);
   const baseUrl = normalizeBaseUrl(remoteBaseUrl ?? configuredProvider?.baseUrl);
   const model = normalizeModel(options.model, options.provider);
@@ -412,17 +417,15 @@ async function createOpenAICompatibleEmbeddingClient(
   });
   const localServiceOptions = options as LocalServiceAwareEmbeddingOptions;
   return {
+    providerId,
     baseUrl,
     headers,
     ssrfPolicy: ssrfPolicyFromHttpBaseUrlAllowedHostname(baseUrl),
     model,
     ...(configuredProvider?.localService && !remoteBaseUrl
       ? {
           localServiceTarget: {
-            providerId:
-              resolvedProvider?.providerId ??
-              options.provider?.trim() ??
-              OPENAI_COMPATIBLE_EMBEDDING_PROVIDER_ID,
+            providerId,
             baseUrl,
             headers,
           },
@@ -488,7 +491,7 @@ export const openAICompatibleEmbeddingProviderAdapter: EmbeddingProviderAdapter
         id: OPENAI_COMPATIBLE_EMBEDDING_PROVIDER_ID,
         inlineBatchTimeoutMs: 10 * 60_000,
         cacheKeyData: {
-          provider: OPENAI_COMPATIBLE_EMBEDDING_PROVIDER_ID,
+          provider: client.providerId,
           baseUrl: client.baseUrl,
           model: client.model,
           ...(typeof client.dimensions === "number" ? { dimensions: client.dimensions } : {}),
