fix(gateway): skip ending destroyed plugin responses

steipete · web-flow · commit 4ea595c1ad0b · 2026-07-09T08:44:01.000+01:00
diff --git a/src/gateway/server/plugins-http.test.ts b/src/gateway/server/plugins-http.test.ts
@@ -519,6 +519,33 @@ describe("createGatewayPluginRequestHandler", () => {
       });
     }
   });
+
+  it("does not end a response the plugin already destroyed before throwing", async () => {
+    const log = createPluginLog();
+    const handler = createGatewayPluginRequestHandler({
+      registry: createTestRegistry({
+        httpRoutes: [
+          createRoute({
+            path: "/destroyed",
+            handler: async (_req, res) => {
+              Object.defineProperty(res, "headersSent", { value: true, configurable: true });
+              res.destroy();
+              throw new Error("boom");
+            },
+          }),
+        ],
+      }),
+      log,
+    });
+    const { res, end } = makeMockHttpResponse();
+
+    const handled = await handler({ url: "/destroyed" } as IncomingMessage, res);
+
+    expect(handled).toBe(true);
+    expect(res.destroyed).toBe(true);
+    expect(end).not.toHaveBeenCalled();
+    expect(log.warn).toHaveBeenCalledWith("plugin http route failed (route): Error: boom");
+  });
 });
 
 describe("createGatewayPluginUpgradeHandler", () => {
diff --git a/src/gateway/server/plugins-http.ts b/src/gateway/server/plugins-http.ts
@@ -201,7 +201,7 @@ export function createGatewayPluginRequestHandler(params: {
           res.statusCode = 500;
           res.setHeader("Content-Type", "text/plain; charset=utf-8");
           res.end("Internal Server Error");
-        } else if (!res.writableEnded) {
+        } else if (!res.writableEnded && !res.destroyed) {
           res.end();
         }
         return true;

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ export function createGatewayPluginRequestHandler(params: {`
`201`	`201`	`res.statusCode = 500;`
`202`	`202`	`res.setHeader("Content-Type", "text/plain; charset=utf-8");`
`203`	`203`	`res.end("Internal Server Error");`
`204`		`- } else if (!res.writableEnded) {`
	`204`	`+ } else if (!res.writableEnded && !res.destroyed) {`
`205`	`205`	`res.end();`
`206`	`206`	`}`
`207`	`207`	`return true;`