msteams: allow replyStyle config override for direct messages

mattjcorner · claude · mattjcorner · commit 4e3d709542f3 · 2026-02-26T11:55:28.000-05:00
DM conversations were hardcoded to replyStyle "thread", which reuses
the original webhook TurnContext. Bot Framework revokes this proxy
after the HTTP handler returns (~15-30s). When agent processing takes
longer (LLM inference, tool calls), the final reply hits the revoked
proxy and fails silently — the user sees "Let me try..." but never
gets the actual response.

The "top-level" replyStyle uses adapter.continueConversation() which
creates a fresh TurnContext per send with no expiry. This change lets
DMs respect the same config cascade (channel → team → global) as
group conversations, defaulting to "thread" for backwards compat.

Operators hitting proxy-revoked errors in DMs can now set
replyStyle: "top-level" in their msteams channel config.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/extensions/msteams/src/policy.test.ts b/extensions/msteams/src/policy.test.ts
@@ -76,14 +76,22 @@ describe("msteams policy", () => {
   });
 
   describe("resolveMSTeamsReplyPolicy", () => {
-    it("forces thread replies for direct messages", () => {
+    it("defaults to thread replies for direct messages", () => {
       const policy = resolveMSTeamsReplyPolicy({
         isDirectMessage: true,
-        globalConfig: { replyStyle: "top-level", requireMention: false },
+        globalConfig: {},
       });
       expect(policy).toEqual({ requireMention: false, replyStyle: "thread" });
     });
 
+    it("respects globalConfig replyStyle override for direct messages", () => {
+      const policy = resolveMSTeamsReplyPolicy({
+        isDirectMessage: true,
+        globalConfig: { replyStyle: "top-level", requireMention: false },
+      });
+      expect(policy).toEqual({ requireMention: false, replyStyle: "top-level" });
+    });
+
     it("defaults to requireMention=true and replyStyle=thread", () => {
       const policy = resolveMSTeamsReplyPolicy({
         isDirectMessage: false,
diff --git a/extensions/msteams/src/policy.ts b/extensions/msteams/src/policy.ts
@@ -221,7 +221,12 @@ export function resolveMSTeamsReplyPolicy(params: {
   channelConfig?: MSTeamsChannelConfig;
 }): MSTeamsReplyPolicy {
   if (params.isDirectMessage) {
-    return { requireMention: false, replyStyle: "thread" };
+    const replyStyle: MSTeamsReplyStyle =
+      params.channelConfig?.replyStyle ??
+      params.teamConfig?.replyStyle ??
+      params.globalConfig?.replyStyle ??
+      "thread";
+    return { requireMention: false, replyStyle };
   }
 
   const requireMention =
