fix(test): avoid scanning live shard roots

vincentkoc · vincentkoc · commit 4b940f66fda0 · 2026-05-16T14:22:48.000+08:00
diff --git a/scripts/test-live-shard.mjs b/scripts/test-live-shard.mjs
@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+import { spawnSync } from "node:child_process";
 import fs from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
@@ -64,13 +65,83 @@ function walkFiles(rootDir) {
 }
 
 export function collectAllLiveTestFiles(repoRoot = process.cwd()) {
+  const externalFiles = listExternalLiveTestFiles(repoRoot);
+  if (externalFiles) {
+    return externalFiles;
+  }
   return ["src", "test", "extensions"]
     .flatMap((dir) => walkFiles(path.join(repoRoot, dir)))
     .map((file) => path.relative(repoRoot, file).split(path.sep).join("/"))
     .filter((file) => file.endsWith(LIVE_TEST_SUFFIX))
     .toSorted((a, b) => a.localeCompare(b));
 }
 
+function listExternalLiveTestFiles(repoRoot) {
+  return listGitLiveTestFiles(repoRoot) ?? listFindLiveTestFiles(repoRoot);
+}
+
+function listGitLiveTestFiles(repoRoot) {
+  const result = spawnSync("git", ["ls-files", "--", "src", "test", "extensions"], {
+    cwd: repoRoot,
+    encoding: "utf8",
+    maxBuffer: 1024 * 1024 * 4,
+    stdio: ["ignore", "pipe", "ignore"],
+  });
+  if (result.status !== 0) {
+    return null;
+  }
+  return result.stdout
+    .split("\n")
+    .map((line) => line.trim())
+    .filter((file) => file.endsWith(LIVE_TEST_SUFFIX))
+    .toSorted((a, b) => a.localeCompare(b));
+}
+
+function listFindLiveTestFiles(repoRoot) {
+  const roots = ["src", "test", "extensions"].map((dir) => path.join(repoRoot, dir));
+  const result = spawnSync(
+    "find",
+    [
+      ...roots,
+      "(",
+      "-name",
+      "node_modules",
+      "-o",
+      "-name",
+      "dist",
+      "-o",
+      "-name",
+      "vendor",
+      "-o",
+      "-name",
+      "fixtures",
+      ")",
+      "-prune",
+      "-o",
+      "-type",
+      "f",
+      "-name",
+      `*${LIVE_TEST_SUFFIX}`,
+      "-print",
+    ],
+    {
+      cwd: repoRoot,
+      encoding: "utf8",
+      maxBuffer: 1024 * 1024 * 4,
+      stdio: ["ignore", "pipe", "ignore"],
+    },
+  );
+  if (result.status !== 0) {
+    return null;
+  }
+  return result.stdout
+    .split("\n")
+    .map((line) => line.trim())
+    .filter((file) => file.length > 0)
+    .map((file) => path.relative(repoRoot, file).split(path.sep).join("/"))
+    .toSorted((a, b) => a.localeCompare(b));
+}
+
 function extensionKey(file) {
   const relative = file.slice("extensions/".length);
   return relative.split("/", 1)[0]?.toLowerCase() ?? "";
diff --git a/test/scripts/test-live-shard.test.ts b/test/scripts/test-live-shard.test.ts
@@ -1,5 +1,5 @@
-import { readFileSync } from "node:fs";
-import { describe, expect, it } from "vitest";
+import fs, { readFileSync } from "node:fs";
+import { describe, expect, it, vi } from "vitest";
 import {
   LIVE_TEST_SHARDS,
   RELEASE_LIVE_TEST_SHARDS,
@@ -10,6 +10,19 @@ import {
 describe("scripts/test-live-shard", () => {
   const allFiles = collectAllLiveTestFiles();
 
+  it("discovers live tests without scanning source roots in-process", () => {
+    const readDir = vi.spyOn(fs, "readdirSync");
+    try {
+      const files = collectAllLiveTestFiles();
+
+      expect(files.length).toBeGreaterThan(0);
+      expect(files.every((file) => file.endsWith(".live.test.ts"))).toBe(true);
+      expect(readDir).not.toHaveBeenCalled();
+    } finally {
+      readDir.mockRestore();
+    }
+  });
+
   it("covers every native live test and tracks provider-filtered release fanout", () => {
     const selected = RELEASE_LIVE_TEST_SHARDS.flatMap((shard) =>
       selectLiveShardFiles(shard, allFiles).map((file) => ({ file, shard })),
