test(nostr): preserve inbound sanitizer coverage

miorbnli · miorbnli · commit 4947413d6f0e · 2026-07-19T18:58:08.000+08:00
diff --git a/extensions/nostr/src/channel.inbound.test.ts b/extensions/nostr/src/channel.inbound.test.ts
@@ -47,10 +47,10 @@ function createMockBus() {
   };
 }
 
-function createRuntimeHarness(deliveredText = "|a|b|") {
+function createRuntimeHarness() {
   const recordInboundSession = vi.fn(async () => {});
   const dispatchReplyWithBufferedBlockDispatcher = vi.fn(async ({ dispatcherOptions }) => {
-    await dispatcherOptions.deliver({ text: deliveredText });
+    await dispatcherOptions.deliver({ text: "|a|b|" });
   });
   const convertMarkdownTables = vi.fn((text: string) => `converted:${text}`);
   const runtime = {
@@ -99,9 +99,8 @@ function createRuntimeHarness(deliveredText = "|a|b|") {
 async function startGatewayHarness(params: {
   account: ReturnType<typeof buildResolvedNostrAccount>;
   cfg?: Parameters<typeof createStartAccountContext>[0]["cfg"];
-  deliveredText?: string;
 }) {
-  const harness = createRuntimeHarness(params.deliveredText);
+  const harness = createRuntimeHarness();
   const bus = createMockBus();
   setNostrRuntime(harness.runtime);
   mocks.startNostrBus.mockResolvedValueOnce(bus as never);
@@ -244,27 +243,45 @@ describe("nostr inbound gateway path", () => {
       expectedText: null,
     },
   ])("$name", async ({ deliveredText, expectedText }) => {
+    mocks.dispatchInboundDirectDm.mockImplementationOnce(
+      async (params: Parameters<typeof DispatchInboundDirectDm>[0]) => {
+        await params.deliver({ text: deliveredText });
+      },
+    );
     const { harness, cleanup } = await startGatewayHarness({
       account: buildResolvedNostrAccount({
         publicKey: "bot-pubkey",
         config: { dmPolicy: "allowlist", allowFrom: ["nostr:sender-pubkey"] },
       }),
-      deliveredText,
     });
     const options = mockCallArg(mocks.startNostrBus) as {
       onMessage: (
         senderPubkey: string,
         text: string,
         reply: (text: string) => Promise<void>,
         meta: { eventId: string; createdAt: number },
+        lifecycle: NostrIngressLifecycle,
       ) => Promise<void>;
     };
     const sendReply = vi.fn(async (_text: string) => {});
+    const lifecycle: NostrIngressLifecycle = {
+      abortSignal: new AbortController().signal,
+      onAdopted: vi.fn(async () => {}),
+      onDeferred: vi.fn(),
+      onAdoptionFinalizing: vi.fn(),
+      onAbandoned: vi.fn(async () => {}),
+    };
 
-    await options.onMessage("sender-pubkey", "hello from nostr", sendReply, {
-      eventId: "event-123",
-      createdAt: 1_710_000_000,
-    });
+    await options.onMessage(
+      "sender-pubkey",
+      "hello from nostr",
+      sendReply,
+      {
+        eventId: "event-123",
+        createdAt: 1_710_000_000,
+      },
+      lifecycle,
+    );
 
     if (expectedText === null) {
       expect(harness.convertMarkdownTables).not.toHaveBeenCalled();
diff --git a/extensions/nostr/src/gateway.ts b/extensions/nostr/src/gateway.ts
@@ -198,7 +198,7 @@ export const startNostrGatewayAccount: NostrGatewayStart = async (ctx) => {
               if (!outboundText.trim()) {
                 return;
               }
-// The gateway inbound reply path bypasses the outbound adapter, so
+              // The gateway inbound reply path bypasses the outbound adapter, so
               // strip internal tool-trace scaffolding here too — matching the
               // sanitizeText hook on nostrOutboundAdapter.
               const sanitizedText = sanitizeAssistantVisibleText(outboundText);

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ export const startNostrGatewayAccount: NostrGatewayStart = async (ctx) => {`
`198`	`198`	`if (!outboundText.trim()) {`
`199`	`199`	`return;`
`200`	`200`	`}`
`201`		`-// The gateway inbound reply path bypasses the outbound adapter, so`
	`201`	`+ // The gateway inbound reply path bypasses the outbound adapter, so`
`202`	`202`	`// strip internal tool-trace scaffolding here too — matching the`
`203`	`203`	`// sanitizeText hook on nostrOutboundAdapter.`
`204`	`204`	`const sanitizedText = sanitizeAssistantVisibleText(outboundText);`