fix: add windowsHide to all spawn calls to prevent visible console windows on Windows

shihao-lao · shihao-lao · commit 4783158b3221 · 2026-06-26T01:40:41.000+08:00
Fixes #96835 Multiple spawn() calls across the codebase were missing the windowsHide: true option, causing visible cmd/PowerShell console windows to flash on every command execution on Windows. This was a regression from previous behavior. Files fixed: - src/agents/sessions/exec.ts - src/agents/sessions/tools/find.ts - src/agents/sessions/tools/grep.ts - src/agents/tool-search.ts - src/agents/provider-local-service.ts - src/agents/sandbox/ssh.ts (3 spawn calls) - src/auto-reply/reply/stage-sandbox-media.ts - src/daemon/launchd-restart-handoff.ts - src/process/respawn-child-runner.ts
diff --git a/src/agents/provider-local-service.ts b/src/agents/provider-local-service.ts
@@ -266,6 +266,7 @@ async function startAndWaitForLocalService(params: {
     env: service.env ? { ...process.env, ...service.env } : process.env,
     stdio: "ignore",
     detached: shouldDetachChildForProcessTree(),
+    windowsHide: true,
   });
   const child = managed.process;
   managed.lastExit = undefined;
diff --git a/src/agents/sandbox/ssh.ts b/src/agents/sandbox/ssh.ts
@@ -624,6 +624,7 @@ export async function runSshSandboxCommand(
       stdio: ["pipe", "pipe", "pipe"],
       env: sshEnv,
       signal: params.signal,
+      windowsHide: true,
     });
     const stdoutChunks: Buffer[] = [];
     const stderrChunks: Buffer[] = [];
@@ -723,11 +724,13 @@ export async function uploadDirectoryToSshTarget(params: {
     const tar = spawn("tar", ["-C", params.localDir, "-cf", "-", "."], {
       stdio: ["ignore", "pipe", "pipe"],
       signal: params.signal,
+      windowsHide: true,
     });
     const ssh = spawn(sshArgv[0], sshArgv.slice(1), {
       stdio: ["pipe", "pipe", "pipe"],
       env: sshEnv,
       signal: params.signal,
+      windowsHide: true,
     });
     const tarStderr: Buffer[] = [];
     const sshStdout: Buffer[] = [];
diff --git a/src/agents/sessions/exec.ts b/src/agents/sessions/exec.ts
@@ -83,6 +83,7 @@ export async function execCommand(
       cwd,
       shell: false,
       stdio: ["ignore", "pipe", "pipe"],
+      windowsHide: true,
     });
 
     let stdout: OutputCapture = { text: "", truncatedChars: 0 };
diff --git a/src/agents/sessions/tools/find.ts b/src/agents/sessions/tools/find.ts
@@ -271,7 +271,7 @@ export function createFindToolDefinition(
             }
             args.push("--", effectivePattern, searchPath);
 
-            const child = spawn(fdPath, args, { stdio: ["ignore", "pipe", "pipe"] });
+            const child = spawn(fdPath, args, { stdio: ["ignore", "pipe", "pipe"], windowsHide: true });
             const rl = createInterface({ input: child.stdout });
             let stderr = "";
             const lines: string[] = [];
diff --git a/src/agents/sessions/tools/grep.ts b/src/agents/sessions/tools/grep.ts
@@ -235,7 +235,7 @@ export function createGrepToolDefinition(
             }
             args.push("--", pattern, searchPath);
 
-            const child = spawn(rgPath, args, { stdio: ["ignore", "pipe", "pipe"] });
+            const child = spawn(rgPath, args, { stdio: ["ignore", "pipe", "pipe"], windowsHide: true });
             const rl = createInterface({ input: child.stdout });
             let stderr = "";
             let matchCount = 0;
diff --git a/src/agents/tool-search.ts b/src/agents/tool-search.ts
@@ -2107,6 +2107,7 @@ function runCodeModeChild(params: {
       cwd: os.tmpdir(),
       env: {},
       stdio: ["ignore", "pipe", "pipe", "ipc"],
+      windowsHide: true,
     });
     const stderr: string[] = [];
     let settled = false;
diff --git a/src/auto-reply/reply/stage-sandbox-media.ts b/src/auto-reply/reply/stage-sandbox-media.ts
@@ -331,7 +331,7 @@ async function scpFile(remoteHost: string, remotePath: string, localPath: string
         `${safeRemoteHost}:${safeRemotePath}`,
         localPath,
       ],
-      { stdio: ["ignore", "ignore", "pipe"] },
+      { stdio: ["ignore", "ignore", "pipe"], windowsHide: true },
     );
 
     let stderr = "";
diff --git a/src/daemon/launchd-restart-handoff.ts b/src/daemon/launchd-restart-handoff.ts
@@ -246,6 +246,7 @@ export function scheduleDetachedLaunchdRestartHandoff(params: {
         detached: true,
         stdio: "ignore",
         env: restartEnv,
+        windowsHide: true,
       },
     );
     child.unref();
diff --git a/src/process/respawn-child-runner.ts b/src/process/respawn-child-runner.ts
@@ -30,6 +30,7 @@ export function runRespawnChildWithSignalBridge(params: {
     stdio: "inherit",
     env,
     detached: detachForProcessTree,
+    windowsHide: true,
   });
 
   // Let the child honor forwarded signals first; then terminate it so the

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ export function createFindToolDefinition(`
`271`	`271`	`}`
`272`	`272`	`args.push("--", effectivePattern, searchPath);`
`273`	`273`
`274`		`- const child = spawn(fdPath, args, { stdio: ["ignore", "pipe", "pipe"] });`
	`274`	`+ const child = spawn(fdPath, args, { stdio: ["ignore", "pipe", "pipe"], windowsHide: true });`
`275`	`275`	`const rl = createInterface({ input: child.stdout });`
`276`	`276`	`let stderr = "";`
`277`	`277`	`const lines: string[] = [];`
Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,7 @@ export function createGrepToolDefinition(`
`235`	`235`	`}`
`236`	`236`	`args.push("--", pattern, searchPath);`
`237`	`237`
`238`		`- const child = spawn(rgPath, args, { stdio: ["ignore", "pipe", "pipe"] });`
	`238`	`+ const child = spawn(rgPath, args, { stdio: ["ignore", "pipe", "pipe"], windowsHide: true });`
`239`	`239`	`const rl = createInterface({ input: child.stdout });`
`240`	`240`	`let stderr = "";`
`241`	`241`	`let matchCount = 0;`