fix(scripts): clamp openwebui probe timer

vincentkoc · vincentkoc · commit 45a93b8450f7 · 2026-06-22T03:18:24.000+02:00
diff --git a/scripts/e2e/lib/openwebui/http-probe.mjs b/scripts/e2e/lib/openwebui/http-probe.mjs
@@ -2,13 +2,20 @@
 import { pathToFileURL } from "node:url";
 import { readPositiveIntEnv } from "../env-limits.mjs";
 
+const MAX_TIMER_TIMEOUT_MS = 2_147_000_000;
+
 function parseExpectedStatus(raw) {
   if (!/^[1-5]\d\d$/u.test(raw)) {
     throw new Error(`expected status must be lt500 or a decimal HTTP status. Got: ${raw}`);
   }
   return Number(raw);
 }
 
+function resolveTimerTimeoutMs(valueMs, fallbackMs) {
+  const value = Number.isFinite(valueMs) ? valueMs : fallbackMs;
+  return Math.min(Math.max(Math.floor(value), 1), MAX_TIMER_TIMEOUT_MS);
+}
+
 export async function probeHttpStatus({
   url,
   expectedRaw = "200",
@@ -20,8 +27,9 @@ export async function probeHttpStatus({
     throw new Error("usage: http-probe.mjs <url> [status|lt500]");
   }
   const expectedStatus = expectedRaw === "lt500" ? undefined : parseExpectedStatus(expectedRaw);
+  const resolvedTimeoutMs = resolveTimerTimeoutMs(timeoutMs, 30_000);
   const controller = new AbortController();
-  const timer = setTimeout(() => controller.abort(), timeoutMs);
+  const timer = setTimeout(() => controller.abort(), resolvedTimeoutMs);
   let res;
   const headers = {};
   if (bearer) {
diff --git a/test/scripts/e2e-helper-env-limits.test.ts b/test/scripts/e2e-helper-env-limits.test.ts
@@ -4,6 +4,7 @@ import fs from "node:fs";
 import { createServer, type Server } from "node:http";
 import os from "node:os";
 import path from "node:path";
+import { MAX_TIMER_TIMEOUT_MS } from "@openclaw/normalization-core/number-coercion";
 import { describe, expect, it } from "vitest";
 import { createBoundedChildOutput } from "../helpers/bounded-child-output.js";
 
@@ -236,4 +237,30 @@ describe("e2e helper numeric env limits", () => {
     ).resolves.toBe(true);
     expect(canceled).toBe(true);
   });
+
+  it("clamps oversized Open WebUI HTTP probe timers before scheduling", async () => {
+    const { probeHttpStatus } = await import("../../scripts/e2e/lib/openwebui/http-probe.mjs");
+    const fetchImpl = (async (_url: string, init: RequestInit) => {
+      await new Promise<void>((resolve, reject) => {
+        const timer = setTimeout(resolve, 25);
+        init.signal?.addEventListener(
+          "abort",
+          () => {
+            clearTimeout(timer);
+            reject(new Error("aborted"));
+          },
+          { once: true },
+        );
+      });
+      return new Response(null, { status: 200 });
+    }) as typeof fetch;
+
+    await expect(
+      probeHttpStatus({
+        fetchImpl,
+        timeoutMs: MAX_TIMER_TIMEOUT_MS + 1,
+        url: "http://127.0.0.1/probe",
+      }),
+    ).resolves.toBe(true);
+  });
 });
