fix(msteams): prevent toPluginJsonValue from crashing on unserializable values

wanyongstar · wanyongstar · commit 440b24f79b10 · 2026-07-20T20:22:51.000+08:00
toPluginJsonValue serializes plugin values through JSON.stringify+parse
without a try/catch guard, so BigInt, circular references, or other
unserializable values cause an unhandled TypeError that propagates to
the caller and may tear down the MSTeams plugin runtime.

Wrap the JSON round-trip in try/catch and return the original value
when serialization fails, matching the defensive pattern already used
by toCodeModeJsonSafe.
diff --git a/extensions/msteams/src/sqlite-state.ts b/extensions/msteams/src/sqlite-state.ts
@@ -43,8 +43,12 @@ export function resolveMSTeamsSqliteStateEnv(
 }
 
 export function toPluginJsonValue<T>(value: T): T {
-  const serialized = JSON.stringify(value);
-  return JSON.parse(serialized) as T;
+  try {
+    const serialized = JSON.stringify(value);
+    return JSON.parse(serialized) as T;
+  } catch {
+    return value;
+  }
 }
 
 function resolveMSTeamsSqliteStateDir(options: MSTeamsSqliteStateOptions | undefined): string {

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,12 @@ export function resolveMSTeamsSqliteStateEnv(`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`export function toPluginJsonValue<T>(value: T): T {`
`46`		`- const serialized = JSON.stringify(value);`
`47`		`- return JSON.parse(serialized) as T;`
	`46`	`+ try {`
	`47`	`+ const serialized = JSON.stringify(value);`
	`48`	`+ return JSON.parse(serialized) as T;`
	`49`	`+ } catch {`
	`50`	`+ return value;`
	`51`	`+ }`
`48`	`52`	`}`
`49`	`53`
`50`	`54`	`function resolveMSTeamsSqliteStateDir(options: MSTeamsSqliteStateOptions \| undefined): string {`