Skip to content

Commit 4361273

Browse files
Jasmine ZhangJasmine Zhang
authored andcommitted
fix: remove duplicate talk select label text
1 parent 4d0f19a commit 4361273

3 files changed

Lines changed: 10 additions & 23 deletions

File tree

ui/src/styles/chat/layout.css

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1108,14 +1108,6 @@
11081108
box-shadow: var(--focus-ring);
11091109
}
11101110

1111-
.agent-chat__talk-select-label {
1112-
min-width: 0;
1113-
overflow: hidden;
1114-
line-height: 1.35;
1115-
text-overflow: ellipsis;
1116-
white-space: nowrap;
1117-
}
1118-
11191111
.agent-chat__talk-select-icon,
11201112
.agent-chat__talk-select-check {
11211113
display: inline-flex;

ui/src/ui/views/chat.test.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1476,11 +1476,11 @@ describe("chat voice controls", () => {
14761476
const model = container.querySelector<HTMLInputElement>(
14771477
'.agent-chat__talk-options-primary input[placeholder="Auto"]',
14781478
);
1479-
const sensitivityLabel = requireElement(
1479+
const sensitivitySelect = requireElement(
14801480
container,
1481-
'[data-talk-select="sensitivity"] .agent-chat__talk-select-label',
1482-
"Talk sensitivity selected label",
1483-
);
1481+
'[data-talk-select="sensitivity"] select',
1482+
"Talk sensitivity select",
1483+
) as HTMLSelectElement;
14841484

14851485
expect(getTalkSelectOptionValues(container, "voice")).toEqual([
14861486
"",
@@ -1495,7 +1495,7 @@ describe("chat voice controls", () => {
14951495
"marin",
14961496
"cedar",
14971497
]);
1498-
expect(sensitivityLabel.textContent).toBe("Custom");
1498+
expect(sensitivitySelect.value).toBe("__custom");
14991499
expect(getTalkSelectOptionValues(container, "sensitivity")).toEqual([
15001500
"",
15011501
"0.65",
@@ -1542,12 +1542,12 @@ describe("chat voice controls", () => {
15421542
},
15431543
onRealtimeTalkOptionsChange,
15441544
});
1545-
const defaultSensitivityLabel = requireElement(
1545+
const defaultSensitivitySelect = requireElement(
15461546
defaultContainer,
1547-
'[data-talk-select="sensitivity"] .agent-chat__talk-select-label',
1548-
"default Talk sensitivity selected label",
1549-
);
1550-
expect(defaultSensitivityLabel.textContent).toBe("Default");
1547+
'[data-talk-select="sensitivity"] select',
1548+
"default Talk sensitivity select",
1549+
) as HTMLSelectElement;
1550+
expect(defaultSensitivitySelect.value).toBe("");
15511551
expect(getTalkSelectOptionValues(defaultContainer, "sensitivity")).toEqual([
15521552
"",
15531553
"0.65",

ui/src/ui/views/chat.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,14 +292,9 @@ function renderNativeTalkSelect(params: {
292292
onSelect: (value: string) => void;
293293
selectedLabel?: string;
294294
}) {
295-
const selectedLabel =
296-
params.selectedLabel ?? params.options.find((entry) => entry.value === params.value)?.label;
297295
return html`
298296
<label class="agent-chat__talk-field" data-talk-select=${params.label.toLowerCase()}>
299297
<span>${params.label}</span>
300-
${selectedLabel
301-
? html`<span class="agent-chat__talk-select-label">${selectedLabel}</span>`
302-
: nothing}
303298
<select
304299
.value=${params.value}
305300
@change=${(event: Event) =>

0 commit comments

Comments
 (0)