fix(zai): preserve minimal thinking semantics

steipete · steipete · commit 432214158a39 · 2026-06-20T23:49:49.000-04:00
diff --git a/extensions/zai/index.test.ts b/extensions/zai/index.test.ts
@@ -346,6 +346,37 @@ describe("zai provider plugin", () => {
     expect(capturedPayload?.thinking).toEqual({ type: "disabled" });
   });
 
+  it("keeps minimal thinking enabled for binary GLM models", async () => {
+    const provider = await registerSingleProviderPlugin(plugin);
+    let capturedPayload: Record<string, unknown> | undefined;
+    const baseStreamFn: StreamFn = (model, _context, options) => {
+      const payload: Record<string, unknown> = {};
+      options?.onPayload?.(payload as never, model as never);
+      capturedPayload = payload;
+      return {} as ReturnType<StreamFn>;
+    };
+
+    const wrapped = provider.wrapStreamFn?.({
+      provider: "zai",
+      modelId: "glm-5.1",
+      extraParams: {},
+      thinkingLevel: "minimal",
+      streamFn: baseStreamFn,
+    } as never);
+
+    void wrapped?.(
+      {
+        api: "openai-completions",
+        provider: "zai",
+        id: "glm-5.1",
+      } as Model<"openai-completions">,
+      { messages: [] } as Context,
+      {},
+    );
+
+    expect(capturedPayload).not.toHaveProperty("thinking");
+  });
+
   it("maps GLM-5.2 thinking levels to Z.AI reasoning effort", async () => {
     const provider = await registerSingleProviderPlugin(plugin);
     const baseStreamFn: StreamFn = (model, _context, options) => {
diff --git a/extensions/zai/index.ts b/extensions/zai/index.ts
@@ -125,7 +125,7 @@ function shouldPreserveZaiThinking(extraParams?: Record<string, unknown>): boole
 }
 
 function isDisabledThinkingLevel(thinkingLevel: ProviderWrapStreamFnContext["thinkingLevel"]) {
-  return thinkingLevel === "off" || thinkingLevel === "minimal";
+  return thinkingLevel === "off";
 }
 
 function isGlm52ModelId(modelId?: string | null): boolean {

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ function shouldPreserveZaiThinking(extraParams?: Record<string, unknown>): boole`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`function isDisabledThinkingLevel(thinkingLevel: ProviderWrapStreamFnContext["thinkingLevel"]) {`
`128`		`- return thinkingLevel === "off" \|\| thinkingLevel === "minimal";`
	`128`	`+ return thinkingLevel === "off";`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`function isGlm52ModelId(modelId?: string \| null): boolean {`