fix(feishu): add early event-level dedup to prevent duplicate message processing

zhuowater · zhuowater · commit 42e6b3c553a3 · 2026-03-06T17:09:40.000+08:00
Feishu webhook retries and WebSocket reconnect replays can deliver the same event multiple times. The existing messageId dedup in handleFeishuMessage runs downstream after the debouncer, so two concurrent dispatches of the same event can both enter the pipeline before either records the messageId. Add a synchronous in-memory dedup check at the EventDispatcher handler level using message_id as key with a 5-minute TTL. This catches duplicates immediately when they arrive, before they enter the inbound debouncer or processing queue. The downstream persistent dedup in bot.ts is preserved for cross-restart protection. Closes #37477
diff --git a/extensions/feishu/src/monitor.account.ts b/extensions/feishu/src/monitor.account.ts
@@ -1,6 +1,7 @@
 import * as crypto from "crypto";
 import * as Lark from "@larksuiteoapi/node-sdk";
 import type { ClawdbotConfig, RuntimeEnv, HistoryEntry } from "openclaw/plugin-sdk/feishu";
+import { createDedupeCache } from "openclaw/plugin-sdk/feishu";
 import { resolveFeishuAccount } from "./accounts.js";
 import { raceWithTimeoutAndAbort } from "./async.js";
 import {
@@ -376,10 +377,24 @@ function registerEventHandlers(
     },
   });
 
+  // Early event-level dedup to drop duplicate webhook retries and WebSocket replays
+  // before they enter the debouncer or processing pipeline.  The downstream dedup in
+  // handleFeishuMessage guards against restarts (persistent), but cannot prevent two
+  // concurrent dispatches of the same event from both being enqueued.
+  const eventDedup = createDedupeCache({ ttlMs: 5 * 60 * 1000, maxSize: 2_000 });
+
   eventDispatcher.register({
     "im.message.receive_v1": async (data) => {
+      const event = data as unknown as FeishuMessageEvent;
+      const messageId = event.message?.message_id?.trim();
+      if (messageId) {
+        const eventKey = `${accountId}:evt:${messageId}`;
+        if (!eventDedup.check(eventKey)) {
+          log(`feishu[${accountId}]: dropping duplicate event for message ${messageId}`);
+          return;
+        }
+      }
       const processMessage = async () => {
-        const event = data as unknown as FeishuMessageEvent;
         await inboundDebouncer.enqueue(event);
       };
       if (fireAndForget) {
