test(ci): cover cyclic script declaration barrels

steipete · steipete · commit 42e59df60bf4 · 2026-07-18T02:46:40.000+01:00
diff --git a/scripts/check-script-declarations.mjs b/scripts/check-script-declarations.mjs
@@ -352,6 +352,8 @@ function collectValueExports(filePath, fsImpl, state) {
     return cached;
   }
   if (state.visiting.has(normalizedFilePath)) {
+    // Full cyclic star resolution requires a fixed point. Fail closed instead of
+    // caching a partial map; script barrels can break the cycle with explicit exports.
     return {
       ambiguous: new Set(),
       exports: new Map(),
diff --git a/test/scripts/check-script-declarations.test.ts b/test/scripts/check-script-declarations.test.ts
@@ -172,6 +172,27 @@ describe("script declaration contracts", () => {
     ).toEqual({ checked: 1, issues: [] });
   });
 
+  it("fails closed on cyclic star graphs", () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-script-declarations-"));
+    tempDirs.push(root);
+    fs.mkdirSync(path.join(root, "scripts"), { recursive: true });
+    fs.writeFileSync(path.join(root, "scripts", "a.mjs"), 'export * from "./b.mjs";\n');
+    fs.writeFileSync(
+      path.join(root, "scripts", "b.mjs"),
+      'export const value = 1;\nexport * from "./a.mjs";\n',
+    );
+    fs.writeFileSync(path.join(root, "scripts", "a.d.mts"), "export const value: 1;\n");
+    fs.writeFileSync(path.join(root, "scripts", "b.d.mts"), "export const value: 1;\n");
+
+    const result = verifyScriptDeclarationContracts({
+      root,
+      files: ["scripts/a.d.mts", "scripts/a.mjs", "scripts/b.d.mts", "scripts/b.mjs"],
+    });
+    expect(result.checked).toBe(2);
+    expect(result.issues).toHaveLength(2);
+    expect(result.issues.every((issue) => issue.includes("cyclic star re-export"))).toBe(true);
+  });
+
   it("fails closed on explicit re-exports of ambiguous bindings", () => {
     const root = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-script-declarations-"));
     tempDirs.push(root);

Original file line number	Diff line number	Diff line change
`@@ -352,6 +352,8 @@ function collectValueExports(filePath, fsImpl, state) {`
`352`	`352`	`return cached;`
`353`	`353`	`}`
`354`	`354`	`if (state.visiting.has(normalizedFilePath)) {`
	`355`	`+ // Full cyclic star resolution requires a fixed point. Fail closed instead of`
	`356`	`+ // caching a partial map; script barrels can break the cycle with explicit exports.`
`355`	`357`	`return {`
`356`	`358`	`ambiguous: new Set(),`
`357`	`359`	`exports: new Map(),`