fix(memory): preserve cycle-0 dedup compat, deduplicate tests

wkeything · claude · wkeything · commit 413aa67a1082 · 2026-04-15T01:21:18.000+02:00
Addresses Codex review on #66845: - P1: Restore ?? 0 fallback for compactionCount when memoryFlushCompactionCount is set, preserving backward compat for legacy sessions - P2: Remove duplicate test assertions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/src/auto-reply/reply/memory-flush.ts b/src/auto-reply/reply/memory-flush.ts
@@ -112,14 +112,7 @@ export function hasAlreadyFlushedForCurrentCompaction(
   if (typeof lastFlushAt !== "number") {
     return false;
   }
-  // When compactionCount is undefined the session has never been compacted.
-  // A lastFlushAt of 0 in that state is ambiguous — it may stem from
-  // zero-initialization rather than an actual flush at cycle 0 — so we
-  // require compactionCount to be an explicit number before comparing.
-  if (typeof entry.compactionCount !== "number") {
-    return false;
-  }
-  return lastFlushAt === entry.compactionCount;
+  return lastFlushAt === (entry.compactionCount ?? 0);
 }
 
 /**
diff --git a/src/auto-reply/reply/reply-state.test.ts b/src/auto-reply/reply/reply-state.test.ts
@@ -356,12 +356,12 @@ describe("hasAlreadyFlushedForCurrentCompaction", () => {
     ).toBe(false);
   });
 
-  it("returns false when compactionCount is undefined even if memoryFlushCompactionCount is 0 (zero-initialization edge case)", () => {
+  it("treats missing compactionCount as 0 for backward compat", () => {
     expect(
       hasAlreadyFlushedForCurrentCompaction({
         memoryFlushCompactionCount: 0,
       }),
-    ).toBe(false);
+    ).toBe(true);
   });
 
   it("returns true when both compactionCount and memoryFlushCompactionCount are explicitly 0", () => {
@@ -373,28 +373,10 @@ describe("hasAlreadyFlushedForCurrentCompaction", () => {
     ).toBe(true);
   });
 
-  it("returns false when both compactionCount and memoryFlushCompactionCount are undefined (fresh session)", () => {
+  it("returns false when both fields are undefined (fresh session)", () => {
     expect(hasAlreadyFlushedForCurrentCompaction({})).toBe(false);
   });
 
-  it("returns false when compactionCount is undefined and memoryFlushCompactionCount is undefined", () => {
-    expect(
-      hasAlreadyFlushedForCurrentCompaction({
-        compactionCount: undefined,
-        memoryFlushCompactionCount: undefined,
-      }),
-    ).toBe(false);
-  });
-
-  it("correctly detects flush at cycle 0 when compactionCount is explicit", () => {
-    expect(
-      hasAlreadyFlushedForCurrentCompaction({
-        compactionCount: 0,
-        memoryFlushCompactionCount: 0,
-      }),
-    ).toBe(true);
-  });
-
   it("returns false after compaction advances past last flush", () => {
     expect(
       hasAlreadyFlushedForCurrentCompaction({
