fix(discord): bound voice speaker context cache

zhangguiping-xydt · zhangguiping-xydt · commit 3e9b135b2f61 · 2026-07-19T02:58:54.000+08:00
diff --git a/extensions/discord/src/voice/speaker-context.test.ts b/extensions/discord/src/voice/speaker-context.test.ts
@@ -55,4 +55,25 @@ describe("DiscordVoiceSpeakerContextResolver", () => {
 
     expect(fetchMember).toHaveBeenCalledTimes(2);
   });
+
+  it("evicts the oldest speaker context after the cache reaches its production bound", async () => {
+    vi.useFakeTimers();
+    vi.setSystemTime(new Date("2026-01-01T00:00:00Z"));
+    const fetchMember = vi.fn(async (_guildId: string, userId: string) => ({
+      nickname: userId,
+      roles: [],
+      user: { id: userId, username: userId, globalName: userId },
+    }));
+    const resolver = new DiscordVoiceSpeakerContextResolver({
+      client: createClient(fetchMember),
+    });
+
+    for (let index = 0; index <= 5_000; index += 1) {
+      await resolver.resolveContext("g1", `u${index}`);
+    }
+    await resolver.resolveContext("g1", "u0");
+    await resolver.resolveContext("g1", "u5000");
+
+    expect(fetchMember).toHaveBeenCalledTimes(5_002);
+  });
 });
diff --git a/extensions/discord/src/voice/speaker-context.ts b/extensions/discord/src/voice/speaker-context.ts
@@ -8,6 +8,7 @@ import { resolveDiscordOwnerAccess } from "../monitor/allow-list.js";
 import { formatDiscordUserTag } from "../monitor/format.js";
 
 const SPEAKER_CONTEXT_CACHE_TTL_MS = 60_000;
+const SPEAKER_CONTEXT_CACHE_MAX_ENTRIES = 5_000;
 
 type VoiceSpeakerIdentity = {
   id: string;
@@ -136,6 +137,15 @@ export class DiscordVoiceSpeakerContextResolver {
         ...context,
         expiresAt,
       });
+      // Expiry is checked on lookup, so one-time speakers would otherwise remain
+      // for the full voice-manager lifetime even after their entries expire.
+      while (this.cache.size > SPEAKER_CONTEXT_CACHE_MAX_ENTRIES) {
+        const oldestKey = this.cache.keys().next().value;
+        if (oldestKey === undefined) {
+          break;
+        }
+        this.cache.delete(oldestKey);
+      }
     }
   }
 }
