Skip to content

Commit 3dbbd79

Browse files
lsr911claude
andcommitted
fix(memory): backfill provider.model in createWithAdapter when adapter returns empty string
- Call resolveProviderModel once and reuse the resolved model - Backfill result.provider.model with resolvedModel when adapter returns an empty string, preventing a dirty search index identity Co-Authored-By: Claude <[email protected]> Signed-off-by: lsr911 <[email protected]>
1 parent e4f6357 commit 3dbbd79

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

extensions/memory-core/src/memory/embeddings.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,12 +226,19 @@ async function createWithAdapter(
226226
adapter: MemoryEmbeddingProviderAdapter,
227227
options: CreateEmbeddingProviderOptions,
228228
): Promise<EmbeddingProviderResult> {
229+
const resolvedModel = resolveProviderModel(adapter, options.model);
229230
const result = await adapter.create({
230231
...options,
231-
model: resolveProviderModel(adapter, options.model),
232+
model: resolvedModel,
232233
});
233234
return {
234-
provider: result.provider,
235+
// Backfill provider.model when the adapter returns an empty string so
236+
// callers always see the resolved model name. An empty model string
237+
// during boot can overwrite a correct index identity and leave the
238+
// search index permanently dirty.
239+
provider: result.provider
240+
? { ...result.provider, model: result.provider.model || resolvedModel }
241+
: null,
235242
requestedProvider: options.provider,
236243
runtime: result.runtime,
237244
};

0 commit comments

Comments
 (0)