test(agents): cover internal orphan prompt sources

outdog-hwh · outdog-hwh · commit 3d38ccdcd218 · 2026-06-25T10:28:05.000+08:00
diff --git a/src/agents/embedded-agent-runner/run/attempt.test.ts b/src/agents/embedded-agent-runner/run/attempt.test.ts
@@ -342,6 +342,15 @@ describe("shouldWarnOnOrphanedUserRepair", () => {
   });
 });
 
+const internalSessionStateSourceTools = [
+  "agent_harness_task",
+  "image_generate",
+  "music_generate",
+  "subagent_announce",
+  "subagent_interrupted_resume",
+  "video_generate",
+] as const;
+
 describe("mergeOrphanedTrailingUserPrompt", () => {
   it("merges an orphaned user leaf into the next user-triggered prompt when missing", () => {
     expect(
@@ -361,22 +370,25 @@ describe("mergeOrphanedTrailingUserPrompt", () => {
     });
   });
 
-  it("drops stale internal inter-session leaves instead of shadowing a fresh prompt", () => {
-    expect(
-      mergeOrphanedTrailingUserPrompt({
+  it.each(internalSessionStateSourceTools)(
+    "drops stale internal inter-session %s leaves instead of shadowing a fresh prompt",
+    (sourceTool) => {
+      expect(
+        mergeOrphanedTrailingUserPrompt({
+          prompt: "newest inbound message",
+          trigger: "user",
+          leafMessage: {
+            content: [{ type: "text", text: `NO_REPLY stale ${sourceTool} completion` }],
+            provenance: { kind: "inter_session", sourceTool },
+          } as never,
+        }),
+      ).toEqual({
+        merged: false,
+        removeLeaf: true,
         prompt: "newest inbound message",
-        trigger: "user",
-        leafMessage: {
-          content: [{ type: "text", text: "NO_REPLY stale subagent completion" }],
-          provenance: { kind: "inter_session", sourceTool: "subagent_announce" },
-        } as never,
-      }),
-    ).toEqual({
-      merged: false,
-      removeLeaf: true,
-      prompt: "newest inbound message",
-    });
-  });
+      });
+    },
+  );
 
   it("keeps user-directed inter-session leaves in the repaired prompt", () => {
     expect(
diff --git a/src/agents/embedded-agent-runner/run/transcript-repair-runtime-contract.test.ts b/src/agents/embedded-agent-runner/run/transcript-repair-runtime-contract.test.ts
@@ -23,6 +23,15 @@ afterEach(() => {
   restoreStrategy = undefined;
 });
 
+const internalSessionStateSourceTools = [
+  "agent_harness_task",
+  "image_generate",
+  "music_generate",
+  "subagent_announce",
+  "subagent_interrupted_resume",
+  "video_generate",
+] as const;
+
 describe("embedded agent transcript repair runtime contract", () => {
   it("merges text orphan leaves into the next prompt with the queued marker", () => {
     const result = mergeOrphanedTrailingUserPrompt({
@@ -38,22 +47,25 @@ describe("embedded agent transcript repair runtime contract", () => {
     });
   });
 
-  it("removes internal completion leaves instead of prepending them to a fresh prompt", () => {
-    const result = mergeOrphanedTrailingUserPrompt({
-      prompt: "newest inbound message",
-      trigger: "user",
-      leafMessage: {
-        content: [{ type: "text", text: "NO_REPLY stale subagent completion" }],
-        provenance: { kind: "inter_session", sourceTool: "subagent_announce" },
-      },
-    });
-
-    expect(result).toEqual({
-      merged: false,
-      removeLeaf: true,
-      prompt: "newest inbound message",
-    });
-  });
+  it.each(internalSessionStateSourceTools)(
+    "removes internal %s leaves instead of prepending them to a fresh prompt",
+    (sourceTool) => {
+      const result = mergeOrphanedTrailingUserPrompt({
+        prompt: "newest inbound message",
+        trigger: "user",
+        leafMessage: {
+          content: [{ type: "text", text: `NO_REPLY stale ${sourceTool} completion` }],
+          provenance: { kind: "inter_session", sourceTool },
+        },
+      });
+
+      expect(result).toEqual({
+        merged: false,
+        removeLeaf: true,
+        prompt: "newest inbound message",
+      });
+    },
+  );
 
   it("preserves user-directed inter-session leaves in the repaired prompt", () => {
     const result = mergeOrphanedTrailingUserPrompt({
