fix: catch unhandled promise rejections in fire-and-forget async calls

zhangLei99586 · claude · zhangLei99586 · commit 3c58abd4cef5 · 2026-07-09T08:59:47.000+08:00
Adds .catch() handlers to five async call sites where Promise rejections
were silently discarded via `void`, creating unhandled rejection risks:
- gmail-ops.ts: startGmailWatch renew timer callback
- feishu/monitor.bot-identity.ts: retryBotIdentityProbe fire-and-forget
- feishu/comment-handler.ts: cleanupTypingReaction fire-and-forget
- feishu/comment-dispatcher.ts: typingReaction.cleanup fire-and-forget
- telegram/bot-message-dispatch.ts: reactionApi remove promise chain

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/extensions/feishu/src/comment-dispatcher.ts b/extensions/feishu/src/comment-dispatcher.ts
@@ -93,7 +93,7 @@ export function createFeishuCommentReplyDispatcher(
         );
       },
       onCleanup: () => {
-        void typingReaction.cleanup();
+        void typingReaction.cleanup().catch(() => undefined);
       },
     });
 
diff --git a/extensions/feishu/src/comment-handler.ts b/extensions/feishu/src/comment-handler.ts
@@ -326,6 +326,6 @@ export async function handleFeishuCommentEvent(
       markRunComplete();
       markDispatchIdle();
     }
-    void cleanupTypingReaction();
+    void cleanupTypingReaction().catch(() => undefined);
   }
 }
diff --git a/extensions/feishu/src/monitor.bot-identity.ts b/extensions/feishu/src/monitor.bot-identity.ts
@@ -78,5 +78,7 @@ export function startBotIdentityRecovery(params: {
     `feishu[${accountId}]: requireMention group messages stay gated until bot identity recovery succeeds`,
   );
 
-  void retryBotIdentityProbe(account, accountId, runtime, abortSignal);
+  void retryBotIdentityProbe(account, accountId, runtime, abortSignal).catch((err: unknown) => {
+    log(`feishu[${accountId}]: bot identity background retry threw: ${String(err)}`);
+  });
 }
diff --git a/extensions/telegram/src/bot-message-dispatch.ts b/extensions/telegram/src/bot-message-dispatch.ts
@@ -2964,7 +2964,9 @@ export const dispatchTelegramMessage = async ({
         ackReactionPromise,
         ackReactionValue: ackReactionPromise ? "ack" : null,
         remove: () =>
-          (reactionApi?.(chatId, msg.message_id ?? 0, []) ?? Promise.resolve()).then(() => {}),
+          (reactionApi?.(chatId, msg.message_id ?? 0, []) ?? Promise.resolve())
+            .then(() => {})
+            .catch(() => undefined),
         onError: (err) => {
           if (!msg.message_id) {
             return;

Original file line number	Diff line number	Diff line change
`@@ -326,6 +326,6 @@ export async function handleFeishuCommentEvent(`
`326`	`326`	`markRunComplete();`
`327`	`327`	`markDispatchIdle();`
`328`	`328`	`}`
`329`		`- void cleanupTypingReaction();`
	`329`	`+ void cleanupTypingReaction().catch(() => undefined);`
`330`	`330`	`}`
`331`	`331`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,5 +78,7 @@ export function startBotIdentityRecovery(params: {`
`78`	`78`	`feishu[${accountId}]: requireMention group messages stay gated until bot identity recovery succeeds`,
`79`	`79`	`);`
`80`	`80`
`81`		`- void retryBotIdentityProbe(account, accountId, runtime, abortSignal);`
	`81`	`+ void retryBotIdentityProbe(account, accountId, runtime, abortSignal).catch((err: unknown) => {`
	`82`	+ log(`feishu[${accountId}]: bot identity background retry threw: ${String(err)}`);
	`83`	`+ });`
`82`	`84`	`}`