Skip to content

Commit 3a4c97c

Browse files
steipetesteipete
committed
test: guard server chat agent event mock calls
1 parent 8846a2a commit 3a4c97c

1 file changed

Lines changed: 21 additions & 21 deletions

File tree

‎src/gateway/server-chat.agent-events.test.ts‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ vi.mock("../config/io.js", () => ({
1313
getRuntimeConfig: vi.fn(() => ({})),
1414
}));
1515

16-
vi.mock("../config/io.js", () => ({
17-
getRuntimeConfig: vi.fn(() => ({})),
18-
}));
19-
2016
vi.mock("../infra/heartbeat-visibility.js", () => ({
2117
resolveHeartbeatVisibility: vi.fn(() => ({
2218
showOk: false,
@@ -184,7 +180,7 @@ describe("agent event handler", () => {
184180
payloadIndex: number,
185181
label: string,
186182
) {
187-
const call = mock.mock.calls[index];
183+
const call = mock.mock.calls.at(index);
188184
if (!call) {
189185
throw new Error(`missing ${label} call ${index + 1}`);
190186
}
@@ -930,7 +926,7 @@ describe("agent event handler", () => {
930926
});
931927

932928
expect(broadcastToConnIds).toHaveBeenCalledTimes(1);
933-
expect(broadcastToConnIds.mock.calls[0]?.[0]).toBe("session.tool");
929+
expect(broadcastToConnIds.mock.calls.at(0)?.[0]).toBe("session.tool");
934930
const sessionToolPayload = requireMockPayload(broadcastToConnIds, 0, 1, "session tool payload");
935931
expectRecordFields(sessionToolPayload, {
936932
runId: "run-session-tool",
@@ -953,8 +949,8 @@ describe("agent event handler", () => {
953949
toolCallId: "tool-session-1",
954950
args: { command: "echo hi" },
955951
});
956-
expect(broadcastToConnIds.mock.calls[0]?.[2]).toEqual(new Set(["conn-session"]));
957-
expect(broadcastToConnIds.mock.calls[0]?.[3]).toEqual({ dropIfSlow: true });
952+
expect(broadcastToConnIds.mock.calls.at(0)?.[2]).toEqual(new Set(["conn-session"]));
953+
expect(broadcastToConnIds.mock.calls.at(0)?.[3]).toEqual({ dropIfSlow: true });
958954
resetAgentRunContextForTest();
959955
});
960956

@@ -995,7 +991,7 @@ describe("agent event handler", () => {
995991
});
996992

997993
expect(broadcastToConnIds).toHaveBeenCalledTimes(1);
998-
expect(broadcastToConnIds.mock.calls[0]?.[0]).toBe("agent");
994+
expect(broadcastToConnIds.mock.calls.at(0)?.[0]).toBe("agent");
999995
const runToolPayload = requireMockPayload(broadcastToConnIds, 0, 1, "run tool payload");
1000996
expectRecordFields(runToolPayload, {
1001997
runId: "run-tool-owner",
@@ -1018,7 +1014,7 @@ describe("agent event handler", () => {
10181014
toolCallId: "tool-run-1",
10191015
args: { command: "echo hi" },
10201016
});
1021-
expect(broadcastToConnIds.mock.calls[0]?.[2]).toEqual(new Set(["conn-run"]));
1017+
expect(broadcastToConnIds.mock.calls.at(0)?.[2]).toEqual(new Set(["conn-run"]));
10221018
resetAgentRunContextForTest();
10231019
});
10241020

@@ -1047,7 +1043,7 @@ describe("agent event handler", () => {
10471043
},
10481044
});
10491045

1050-
const payload = nodeSendToSession.mock.calls[0]?.[2] as {
1046+
const payload = nodeSendToSession.mock.calls.at(0)?.[2] as {
10511047
stream?: string;
10521048
data?: { name?: string; args?: Record<string, unknown> };
10531049
};
@@ -1111,8 +1107,8 @@ describe("agent event handler", () => {
11111107
},
11121108
});
11131109

1114-
expect(nodeSendToSession.mock.calls[0]?.[0]).toBe("session-1");
1115-
expect(nodeSendToSession.mock.calls[0]?.[1]).toBe("agent");
1110+
expect(nodeSendToSession.mock.calls.at(0)?.[0]).toBe("session-1");
1111+
expect(nodeSendToSession.mock.calls.at(0)?.[1]).toBe("agent");
11161112
const nodeToolPayload = requireMockPayload(nodeSendToSession, 0, 2, "node tool payload");
11171113
expectRecordFields(nodeToolPayload, {
11181114
runId: "run-tool-node",
@@ -1270,8 +1266,8 @@ describe("agent event handler", () => {
12701266
},
12711267
});
12721268

1273-
expect(broadcastToConnIds.mock.calls[0]?.[0]).toBe("sessions.changed");
1274-
expectPayloadFields(broadcastToConnIds.mock.calls[0]?.[1], {
1269+
expect(broadcastToConnIds.mock.calls.at(0)?.[0]).toBe("sessions.changed");
1270+
expectPayloadFields(broadcastToConnIds.mock.calls.at(0)?.[1], {
12751271
sessionKey: "session-finished",
12761272
phase: "end",
12771273
spawnedBy: "agent:main:main",
@@ -1290,8 +1286,8 @@ describe("agent event handler", () => {
12901286
estimatedCostUsd: 0.12,
12911287
lastThreadId: 42,
12921288
});
1293-
expect(broadcastToConnIds.mock.calls[0]?.[2]).toEqual(new Set(["conn-session"]));
1294-
expect(broadcastToConnIds.mock.calls[0]?.[3]).toEqual({ dropIfSlow: true });
1289+
expect(broadcastToConnIds.mock.calls.at(0)?.[2]).toEqual(new Set(["conn-session"]));
1290+
expect(broadcastToConnIds.mock.calls.at(0)?.[3]).toEqual({ dropIfSlow: true });
12951291
});
12961292

12971293
it("keeps tool output for Control UI recipients when verbose is on", () => {
@@ -1317,7 +1313,9 @@ describe("agent event handler", () => {
13171313
});
13181314

13191315
expect(broadcastToConnIds).toHaveBeenCalledTimes(1);
1320-
const payload = broadcastToConnIds.mock.calls[0]?.[1] as { data?: Record<string, unknown> };
1316+
const payload = broadcastToConnIds.mock.calls.at(0)?.[1] as {
1317+
data?: Record<string, unknown>;
1318+
};
13211319
expect(payload.data?.result).toEqual({ content: [{ type: "text", text: "secret" }] });
13221320
expect(payload.data?.partialResult).toEqual({ content: [{ type: "text", text: "partial" }] });
13231321
resetAgentRunContextForTest();
@@ -1346,7 +1344,9 @@ describe("agent event handler", () => {
13461344
});
13471345

13481346
expect(broadcastToConnIds).toHaveBeenCalledTimes(1);
1349-
const payload = broadcastToConnIds.mock.calls[0]?.[1] as { data?: Record<string, unknown> };
1347+
const payload = broadcastToConnIds.mock.calls.at(0)?.[1] as {
1348+
data?: Record<string, unknown>;
1349+
};
13501350
expect(payload.data?.result).toEqual(result);
13511351
resetAgentRunContextForTest();
13521352
});
@@ -1627,7 +1627,7 @@ describe("agent event handler", () => {
16271627
expect(broadcast.mock.calls.some(([event]) => event === "agent")).toBe(false);
16281628
expect(nodeSendToSession).not.toHaveBeenCalled();
16291629
const persistParams = requireRecord(
1630-
persistGatewaySessionLifecycleEventMock.mock.calls[0]?.[0],
1630+
persistGatewaySessionLifecycleEventMock.mock.calls.at(0)?.[0],
16311631
"persist lifecycle params",
16321632
);
16331633
expect(persistParams.sessionKey).toBe("session-hidden");
@@ -1680,7 +1680,7 @@ describe("agent event handler", () => {
16801680
});
16811681

16821682
expect(broadcastToConnIds).toHaveBeenCalledTimes(1);
1683-
const payload = broadcastToConnIds.mock.calls[0]?.[1] as { runId?: string };
1683+
const payload = broadcastToConnIds.mock.calls.at(0)?.[1] as { runId?: string };
16841684
expect(payload.runId).toBe("run-tool-client");
16851685
resetAgentRunContextForTest();
16861686
});

0 commit comments

Comments
 (0)