fix(clawsweeper): address review for automerge-openclaw-openclaw-86017 (1)

clawsweeper[bot] · clawsweeper[bot] · commit 36d6a3632356 · 2026-05-25T19:09:31.000Z
Co-authored-by: NianJiu &lt;180004567+NianJiuZst@users.noreply.github.com&gt;

Co-authored-by: clawsweeper[bot] &lt;274271284+clawsweeper[bot]@users.noreply.github.com&gt;
diff --git a/extensions/feishu/src/channel.test.ts b/extensions/feishu/src/channel.test.ts
@@ -445,6 +445,43 @@ describe("feishuPlugin actions", () => {
     ).toBe(false);
   });
 
+  it("renders legacy web_app presentation buttons as native Feishu link buttons", async () => {
+    sendCardFeishuMock.mockResolvedValueOnce({ messageId: "om_card", chatId: "oc_group_1" });
+
+    await feishuPlugin.actions?.handleAction?.({
+      action: "send",
+      params: {
+        to: "chat:oc_group_1",
+        presentation: {
+          blocks: [
+            {
+              type: "buttons",
+              buttons: [{ label: "Open app", web_app: { url: "https://example.com/app" } }],
+            },
+          ],
+        },
+      },
+      cfg,
+      accountId: undefined,
+      toolContext: {},
+    } as never);
+
+    const sendCardArgs = requireRecord(
+      mockCallArg(sendCardFeishuMock, 0, 0, "sendCardFeishu"),
+      "send card args",
+    );
+    const card = requireRecord(sendCardArgs.card, "card");
+    const elements = requireArray(requireRecord(card.body, "card body").elements, "card elements");
+    expect(elements).toEqual([
+      {
+        tag: "button",
+        text: { tag: "plain_text", content: "Open app" },
+        type: "default",
+        behaviors: [{ type: "open_url", default_url: "https://example.com/app" }],
+      },
+    ]);
+  });
+
   it("does not duplicate title-only presentation cards in the body fallback", async () => {
     sendCardFeishuMock.mockResolvedValueOnce({ messageId: "om_card", chatId: "oc_group_1" });
 
diff --git a/extensions/feishu/src/outbound.test.ts b/extensions/feishu/src/outbound.test.ts
@@ -490,6 +490,45 @@ describe("feishuOutbound.sendPayload native cards", () => {
     expectFeishuResult(result, "native_card_msg");
   });
 
+  it("renders webApp presentation buttons into Feishu channelData link buttons", async () => {
+    const presentation: MessagePresentation = {
+      blocks: [
+        {
+          type: "buttons",
+          buttons: [{ label: "Open app", webApp: { url: "https://example.com/app" } }],
+        },
+      ],
+    };
+    const payload = { presentation };
+    const rendered = await feishuOutbound.renderPresentation?.({
+      payload,
+      presentation,
+      ctx: {
+        cfg: emptyConfig,
+        to: "chat_1",
+        text: "",
+        accountId: "main",
+        payload,
+      },
+    });
+
+    if (!rendered) {
+      throw new Error("expected Feishu presentation renderer to return a payload");
+    }
+    expect(rendered.text).toBe("- Open app: https://example.com/app");
+    const renderedChannelData = rendered.channelData as
+      | { feishu?: { card?: Record<string, any> } }
+      | undefined;
+    expect(renderedChannelData?.feishu?.card?.body?.elements).toEqual([
+      {
+        tag: "button",
+        text: { tag: "plain_text", content: "Open app" },
+        type: "default",
+        behaviors: [{ type: "open_url", default_url: "https://example.com/app" }],
+      },
+    ]);
+  });
+
   it("does not duplicate title-only presentation cards in outbound fallbacks", async () => {
     const presentation: MessagePresentation = {
       title: "Status",
diff --git a/extensions/feishu/src/presentation-card.ts b/extensions/feishu/src/presentation-card.ts
@@ -36,6 +36,10 @@ function resolveSafeFeishuButtonUrl(url: string | undefined): string | undefined
   }
 }
 
+function resolveFeishuButtonUrl(button: MessagePresentationButton): string | undefined {
+  return button.url ?? button.webApp?.url ?? button.web_app?.url;
+}
+
 function mapFeishuButtonType(style: MessagePresentationButton["style"]) {
   if (style === "primary" || style === "success") {
     return "primary";
@@ -58,8 +62,9 @@ function buildFeishuPayloadButton(
     },
     type: mapFeishuButtonType(button.style),
   };
-  if (button.url) {
-    const safeUrl = resolveSafeFeishuButtonUrl(button.url);
+  const url = resolveFeishuButtonUrl(button);
+  if (url) {
+    const safeUrl = resolveSafeFeishuButtonUrl(url);
     if (safeUrl) {
       behaviors.push({ type: "open_url", default_url: safeUrl });
     }
