fix: reject fractional page numbers in PDF tool page range parser

Linux2010 · Linux2010 · commit 36486b2c3753 · 2026-07-03T22:58:12.000+08:00
parsePageRange used Number(part) which accepts fractional values like "1.5". The document-extract fallback later filters non-integer pages with Number.isInteger, silently dropping them and producing empty extraction results. Add Number.isInteger check at parse time to reject fractional input with a clear error. Closes #99393
diff --git a/src/agents/tools/pdf-tool.helpers.test.ts b/src/agents/tools/pdf-tool.helpers.test.ts
@@ -86,6 +86,14 @@ describe("parsePageRange", () => {
     expect(() => parsePageRange("-1", 20)).toThrow("Invalid page number");
   });
 
+  it("throws on fractional page number", () => {
+    expect(() => parsePageRange("1.5", 20)).toThrow("Invalid page number");
+  });
+
+  it("throws on fractional page number in a comma-separated list", () => {
+    expect(() => parsePageRange("1,1.5", 20)).toThrow("Invalid page number");
+  });
+
   it("handles empty parts gracefully", () => {
     expect(parsePageRange("1,,3", 20)).toEqual([1, 3]);
   });
diff --git a/src/agents/tools/pdf-tool.helpers.ts b/src/agents/tools/pdf-tool.helpers.ts
@@ -66,7 +66,7 @@ export function parsePageRange(range: string, maxPages: number): number[] {
       }
     } else {
       const num = Number(part);
-      if (!Number.isFinite(num) || num < 1) {
+      if (!Number.isFinite(num) || !Number.isInteger(num) || num < 1) {
         throw new Error(`Invalid page number: "${part}"`);
       }
       if (num <= maxPages) {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ export function parsePageRange(range: string, maxPages: number): number[] {`
`66`	`66`	`}`
`67`	`67`	`} else {`
`68`	`68`	`const num = Number(part);`
`69`		`- if (!Number.isFinite(num) \|\| num < 1) {`
	`69`	`+ if (!Number.isFinite(num) \|\| !Number.isInteger(num) \|\| num < 1) {`
`70`	`70`	throw new Error(`Invalid page number: "${part}"`);
`71`	`71`	`}`
`72`	`72`	`if (num <= maxPages) {`