fix(sessions): satisfy test-types, knip export scan, and docs map

steipete · steipete · commit 340da9fbd988 · 2026-07-19T02:38:01.000-07:00
diff --git a/docs/docs_map.md b/docs/docs_map.md
@@ -2492,7 +2492,7 @@ Do not edit it by hand; run `pnpm docs:map:gen`.
   - H2: Home
   - H2: What flows into the main session
   - H2: Memory across resets and conversations
-  - H2: A rolling session, not an immortal one
+  - H2: A rolling session with durable history
   - H2: When you want isolation instead
   - H2: Related
 
diff --git a/src/config/sessions/session-history-eviction.test.ts b/src/config/sessions/session-history-eviction.test.ts
@@ -20,7 +20,6 @@ import { getSessionKysely } from "./session-accessor.sqlite-scope.js";
 import {
   enforceSqliteSessionHistoryDiskBudget,
   kickSessionHistoryDiskBudgetMaintenance,
-  resetSessionHistoryBudgetKicksForTests,
   inspectSqliteSessionHistoryDiskBudget,
 } from "./session-history-eviction.js";
 import { resolveSqliteTargetFromSessionStorePath } from "./session-sqlite-target.js";
@@ -294,7 +293,6 @@ describe("kickSessionHistoryDiskBudgetMaintenance", () => {
   it("throttles repeat kicks and skips warn mode entirely", async () => {
     const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-session-history-kick-"));
     const storePath = path.join(tempDir, "sessions.json");
-    resetSessionHistoryBudgetKicksForTests();
     const maintenance = {
       mode: "warn",
       maxDiskBytes: 1,
@@ -325,7 +323,6 @@ describe("kickSessionHistoryDiskBudgetMaintenance", () => {
     // Give the fire-and-forget pass a tick to settle; an under-budget store
     // must leave every session untouched.
     await new Promise((resolve) => setTimeout(resolve, 50));
-    resetSessionHistoryBudgetKicksForTests();
     closeOpenClawAgentDatabasesForTest();
     fs.rmSync(tempDir, { recursive: true, force: true });
   });
diff --git a/src/config/sessions/session-history-eviction.ts b/src/config/sessions/session-history-eviction.ts
@@ -63,15 +63,10 @@ function createPhysicalBudgetResult(params: {
   };
 }
 
-export type SessionHistoryDiskBudgetInspection = {
-  diskBudget: SessionDiskBudgetSweepResult | null;
-  wouldMutate: boolean;
-};
-
 /** Reports the same physical total enforce mode compares, without projecting logical row bytes. */
 export async function inspectSqliteSessionHistoryDiskBudget(
   params: SessionHistoryDiskBudgetParams,
-): Promise<SessionHistoryDiskBudgetInspection> {
+): Promise<{ diskBudget: SessionDiskBudgetSweepResult | null; wouldMutate: boolean }> {
   const { highWaterBytes, maxDiskBytes } = params.maintenance;
   if (maxDiskBytes == null || highWaterBytes == null) {
     return { diskBudget: null, wouldMutate: false };
@@ -107,7 +102,7 @@ export async function inspectSqliteSessionHistoryDiskBudget(
   return { diskBudget, wouldMutate: candidates.length > 0 };
 }
 
-export function collectProtectedHistoricalSessionIds(params: {
+function collectProtectedHistoricalSessionIds(params: {
   database: OpenClawAgentDatabase;
   storePath: string;
 }): Set<string> {
@@ -207,10 +202,6 @@ const budgetKickStateByStore = new Map<
   { lastCheckAt: number; running: boolean; pendingForce: boolean }
 >();
 
-export function resetSessionHistoryBudgetKicksForTests(): void {
-  budgetKickStateByStore.clear();
-}
-
 /** Fire-and-forget budget pass from the ordinary entry-write maintenance seam. */
 export function kickSessionHistoryDiskBudgetMaintenance(params: {
   agentId?: string;
diff --git a/src/config/sessions/store.session-lifecycle-mutation.test.ts b/src/config/sessions/store.session-lifecycle-mutation.test.ts
@@ -203,17 +203,18 @@ describe("session store lifecycle mutations", () => {
     const sessionIds = ["delete-history-one", "delete-history-two", "delete-history-three"];
     await replaceSessionEntry(
       { sessionKey, storePath },
-      { sessionId: sessionIds[0], updatedAt: 1 },
+      { sessionId: "delete-history-one", updatedAt: 1 },
     );
     for (const [index, sessionId] of sessionIds.entries()) {
       await replaceSqliteTranscriptEvents({ sessionId, sessionKey, storePath }, [
         createSearchableTranscriptEvent(sessionId, `deleteforever generation ${index + 1}`),
       ]);
-      if (index < sessionIds.length - 1) {
+      const nextSessionId = sessionIds[index + 1];
+      if (nextSessionId) {
         await resetSessionEntryLifecycle({
           storePath,
           target: { canonicalKey: sessionKey, storeKeys: [sessionKey] },
-          buildNextEntry: () => ({ sessionId: sessionIds[index + 1], updatedAt: index + 2 }),
+          buildNextEntry: () => ({ sessionId: nextSessionId, updatedAt: index + 2 }),
         });
       }
     }
