fix(hooks): align ACP save callback contract

JohnnyBraver · mantisai-bot · commit 32a0e90de503 · 2026-06-01T18:21:04.000+03:00
diff --git a/src/acp/control-plane/manager.core.ts b/src/acp/control-plane/manager.core.ts
@@ -14,7 +14,6 @@ import {
   triggerInternalHook,
 } from "../../hooks/internal-hooks.js";
 import { formatErrorMessage } from "../../infra/errors.js";
-import { normalizeAgentId } from "../../routing/session-key.js";
 import { isAcpSessionKey } from "../../sessions/session-key-utils.js";
 import { AcpRuntimeError } from "../runtime/errors.js";
 import { runManagerCancelSession } from "./manager.cancel-session.js";
@@ -482,7 +481,7 @@ export class AcpSessionManager {
   }
 
   private normalizeTurnSaveHookResult(
-    result: AcpTurnSaveHookResult | boolean | void,
+    result: AcpTurnSaveHookResult | false | void,
   ): AcpTurnSaveHookResult {
     if (result === false) {
       return { saveOutcome: "skipped", saveSkipReason: "declined" };
diff --git a/src/acp/control-plane/manager.test.ts b/src/acp/control-plane/manager.test.ts
@@ -407,7 +407,7 @@ describe("AcpSessionManager", () => {
       text: "hello",
       mode: "prompt",
       requestId: "turn-save-no-evidence",
-      onBeforeTurnSaveHook: (() => undefined) as never,
+      onBeforeTurnSaveHook: () => undefined,
     });
 
     await vi.waitFor(() => {
@@ -434,7 +434,7 @@ describe("AcpSessionManager", () => {
   it("emits agent:turn:end after terminal ACP events are delivered", async () => {
     const runtimeState = createRuntime();
     runtimeState.runTurn.mockImplementation(async function* () {
-      yield { type: "text_delta" as const, text: "remember this", stream: "content" as const };
+      yield { type: "text_delta" as const, text: "remember this", stream: "output" as const };
       yield { type: "done" as const };
     });
     hoisted.requireAcpRuntimeBackendMock.mockReturnValue({
diff --git a/src/acp/control-plane/manager.types.ts b/src/acp/control-plane/manager.types.ts
@@ -97,7 +97,7 @@ export type AcpRunTurnInput = {
   onEvent?: (event: AcpRuntimeEvent) => Promise<void> | void;
   onBeforeTurnSaveHook?: (
     context: AcpTurnCompletionHookContext,
-  ) => Promise<AcpTurnSaveHookResult | false> | AcpTurnSaveHookResult | false;
+  ) => Promise<AcpTurnSaveHookResult | false | void> | AcpTurnSaveHookResult | false | void;
 };
 
 export type AcpTurnLifecycleEvent = {
