fix(state): tolerate vanished sqlite sidecars in agent-db permission sweep

steipete · steipete · commit 329d5e772f78 · 2026-07-17T00:39:53.000-07:00
existsSync+chmodSync raced SQLite's own WAL/SHM cleanup: a checkpoint or
close between the two calls throws ENOENT (observed from the transcript
reconcile worker in server-startup-web-fetch-bind on CI). chmod directly
and swallow only ENOENT, which removes the TOCTOU window.
diff --git a/src/state/openclaw-agent-db.ts b/src/state/openclaw-agent-db.ts
@@ -577,8 +577,16 @@ export function ensureOpenClawAgentDatabasePermissions(
     chmodSync(dir, OPENCLAW_AGENT_DB_DIR_MODE);
   }
   for (const candidate of resolveSqliteDatabaseFilePaths(pathname)) {
-    if (existsSync(candidate)) {
+    try {
       chmodSync(candidate, OPENCLAW_AGENT_DB_FILE_MODE);
+    } catch (error) {
+      // WAL/SHM/journal sidecars are transient: SQLite removes them at
+      // checkpoint/close, so a concurrent worker can race this sweep. A
+      // vanished sidecar needs no tightening; an existsSync guard would just
+      // reintroduce the TOCTOU window.
+      if ((error as NodeJS.ErrnoException).code !== "ENOENT") {
+        throw error;
+      }
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -577,8 +577,16 @@ export function ensureOpenClawAgentDatabasePermissions(`
`577`	`577`	`chmodSync(dir, OPENCLAW_AGENT_DB_DIR_MODE);`
`578`	`578`	`}`
`579`	`579`	`for (const candidate of resolveSqliteDatabaseFilePaths(pathname)) {`
`580`		`- if (existsSync(candidate)) {`
	`580`	`+ try {`
`581`	`581`	`chmodSync(candidate, OPENCLAW_AGENT_DB_FILE_MODE);`
	`582`	`+ } catch (error) {`
	`583`	`+ // WAL/SHM/journal sidecars are transient: SQLite removes them at`
	`584`	`+ // checkpoint/close, so a concurrent worker can race this sweep. A`
	`585`	`+ // vanished sidecar needs no tightening; an existsSync guard would just`
	`586`	`+ // reintroduce the TOCTOU window.`
	`587`	`+ if ((error as NodeJS.ErrnoException).code !== "ENOENT") {`
	`588`	`+ throw error;`
	`589`	`+ }`
`582`	`590`	`}`
`583`	`591`	`}`
`584`	`592`	`}`