fix(gateway): guard hook job timestamps

steipete · steipete · commit 326db5822920 · 2026-05-30T09:33:19.000-04:00
diff --git a/src/gateway/server.hooks.test.ts b/src/gateway/server.hooks.test.ts
@@ -95,10 +95,18 @@ type HookCronRunCall = {
   sessionKey?: string;
   job?: {
     agentId?: string;
+    createdAtMs?: number;
     payload?: {
       externalContentSource?: string;
       model?: string;
     };
+    schedule?: {
+      kind?: string;
+      at?: string;
+    };
+    state?: {
+      nextRunAtMs?: number;
+    };
   };
 };
 
@@ -792,6 +800,32 @@ describe("gateway server hooks", () => {
     });
   });
 
+  test("dispatches agent hooks when the process clock is outside the Date range", async () => {
+    testState.hooksConfig = { enabled: true, token: HOOK_TOKEN };
+
+    await withGatewayServer(async ({ port }) => {
+      mockIsolatedRunOkOnce();
+      const dateNowSpy = vi.spyOn(Date, "now").mockReturnValue(8_640_000_000_000_001);
+
+      try {
+        const response = await postHook(port, "/hooks/agent", {
+          message: "Bad clock",
+          name: "Clock",
+        });
+        expect(response.status).toBe(200);
+        await waitForSystemEvent();
+      } finally {
+        dateNowSpy.mockRestore();
+      }
+
+      const call = cronRunCall();
+      expect(call.job?.createdAtMs).toBe(0);
+      expect(call.job?.schedule).toEqual({ kind: "at", at: "1970-01-01T00:00:00.000Z" });
+      expect(call.job?.state?.nextRunAtMs).toBe(0);
+      drainSystemEvents(resolveMainKey());
+    });
+  });
+
   test("enforces hooks.allowedAgentIds for effective agent routing", async () => {
     testState.hooksConfig = {
       enabled: true,
diff --git a/src/gateway/server/hooks.ts b/src/gateway/server/hooks.ts
@@ -13,6 +13,10 @@ import type { CronJob } from "../../cron/types.js";
 import { requestHeartbeat } from "../../infra/heartbeat-wake.js";
 import { enqueueSystemEvent } from "../../infra/system-events.js";
 import type { createSubsystemLogger } from "../../logging/subsystem.js";
+import {
+  resolveDateTimestampMs,
+  resolveTimestampMsToIsoString,
+} from "../../shared/number-coercion.js";
 import { normalizeOptionalString } from "../../shared/string-coerce.js";
 import { type HookAgentDispatchPayload, type HooksConfigResolved } from "../hooks.js";
 import { createHooksRequestHandler, type HookClientIpConfig } from "./hooks-request-handler.js";
@@ -105,7 +109,7 @@ export function createGatewayHooksRequestHandler(params: {
     const safeName = sanitizeInboundSystemTags(value.name);
     const jobId = randomUUID();
     const runId = randomUUID();
-    const now = Date.now();
+    const nowMs = resolveDateTimestampMs(Date.now());
     const delivery = value.deliver
       ? {
           mode: "announce" as const,
@@ -118,9 +122,9 @@ export function createGatewayHooksRequestHandler(params: {
       agentId: value.agentId,
       name: safeName,
       enabled: true,
-      createdAtMs: now,
-      updatedAtMs: now,
-      schedule: { kind: "at", at: new Date(now).toISOString() },
+      createdAtMs: nowMs,
+      updatedAtMs: nowMs,
+      schedule: { kind: "at", at: resolveTimestampMsToIsoString(nowMs) },
       sessionTarget: "isolated",
       wakeMode: value.wakeMode,
       payload: {
@@ -133,7 +137,7 @@ export function createGatewayHooksRequestHandler(params: {
         externalContentSource: value.externalContentSource,
       },
       delivery,
-      state: { nextRunAtMs: now },
+      state: { nextRunAtMs: nowMs },
     };
 
     let hookEventSessionKey: string | undefined;
