fix(agents): scope provider failover codes

altaywtf · web-flow · commit 31f75d7864f0 · 2026-07-10T20:09:11.000+03:00
diff --git a/extensions/anthropic/index.test.ts b/extensions/anthropic/index.test.ts
@@ -133,7 +133,7 @@ describe("anthropic provider replay hooks", () => {
         errorMessage: "",
         errorType: "api_error",
       }),
-    ).toBe("timeout");
+    ).toBe("server_error");
     expect(
       provider.classifyFailoverReason?.({
         provider: "anthropic",
@@ -149,6 +149,13 @@ describe("anthropic provider replay hooks", () => {
         code: "RATE_LIMIT_ERROR",
       }),
     ).toBe("rate_limit");
+    expect(
+      provider.classifyFailoverReason?.({
+        provider: "anthropic",
+        errorMessage: "",
+        code: "API_ERROR",
+      }),
+    ).toBe("server_error");
     expect(
       provider.classifyFailoverReason?.({
         provider: "anthropic",
diff --git a/extensions/anthropic/register.runtime.ts b/extensions/anthropic/register.runtime.ts
@@ -65,7 +65,7 @@ function classifyAnthropicFailoverDescriptor(value: string | undefined) {
     case "RATE_LIMIT_ERROR":
       return "rate_limit" as const;
     case "API_ERROR":
-      return "timeout" as const;
+      return "server_error" as const;
     default:
       return undefined;
   }
diff --git a/src/agents/embedded-agent-helpers/errors-provider-structured-signals.test.ts b/src/agents/embedded-agent-helpers/errors-provider-structured-signals.test.ts
@@ -118,7 +118,7 @@ describe("provider failover hook structured signals", () => {
 
   it.each([
     { errorType: "rate_limit_error", reason: "rate_limit", runtimeKind: "rate_limit" },
-    { errorType: "api_error", reason: "timeout", runtimeKind: "timeout" },
+    { errorType: "api_error", reason: "server_error", runtimeKind: "unclassified" },
   ] as const)(
     "classifies message-less Anthropic $errorType assistant failures",
     ({ errorType, reason, runtimeKind }) => {
@@ -129,7 +129,7 @@ describe("provider failover hook structured signals", () => {
         if (context.errorType === "rate_limit_error") {
           return "rate_limit";
         }
-        return context.errorType === "api_error" ? "timeout" : undefined;
+        return context.errorType === "api_error" ? "server_error" : undefined;
       });
 
       const message = makeAssistantMessageFixture({
@@ -150,6 +150,26 @@ describe("provider failover hook structured signals", () => {
     },
   );
 
+  it.each([
+    { provider: "google", code: "SERVER_ERROR" },
+    { provider: "anthropic", code: "INSUFFICIENT_QUOTA" },
+    { provider: "openai", code: "INTERNAL" },
+    { provider: "openai", code: "DEADLINE_EXCEEDED" },
+    { provider: "anthropic", code: "UNAVAILABLE" },
+    { provider: "google", code: "API_ERROR" },
+    { provider: "google", code: "RATE_LIMIT_ERROR" },
+  ] as const)(
+    "does not apply provider-native $code semantics to non-owner $provider",
+    ({ provider, code }) => {
+      providerRuntimeMocks.classifyProviderPluginError.mockReturnValue(undefined);
+
+      expect(classifyFailoverSignal({ provider, code, message: "" })).toBeNull();
+      expect(classifyProviderRuntimeFailureKind({ provider, code, message: "" })).toBe(
+        "unclassified",
+      );
+    },
+  );
+
   it("does not promote generic SDK type strings as structured provider descriptors", () => {
     providerRuntimeMocks.classifyProviderPluginError.mockReturnValue("billing");
 
diff --git a/src/agents/embedded-agent-helpers/errors.ts b/src/agents/embedded-agent-helpers/errors.ts
@@ -919,24 +919,14 @@ function classifyFailoverReasonFromCode(raw: string | undefined): FailoverReason
     case "RATE_LIMIT":
     case "RATE_LIMITED":
     case "RATE_LIMIT_EXCEEDED":
-    case "RATE_LIMIT_ERROR":
     case "TOO_MANY_REQUESTS":
     case "THROTTLED":
     case "THROTTLING":
     case "THROTTLINGEXCEPTION":
     case "THROTTLING_EXCEPTION":
       return "rate_limit";
-    case "INSUFFICIENT_QUOTA":
-      return "billing";
     case "DEACTIVATED_WORKSPACE":
       return "auth_permanent";
-    case "INTERNAL":
-    case "SERVER_ERROR":
-      return "server_error";
-    case "API_ERROR":
-    case "DEADLINE_EXCEEDED":
-      return "timeout";
-    case "UNAVAILABLE":
     case "OVERLOADED":
     case "OVERLOADED_ERROR":
       return "overloaded";

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ function classifyAnthropicFailoverDescriptor(value: string \| undefined) {`
`65`	`65`	`case "RATE_LIMIT_ERROR":`
`66`	`66`	`return "rate_limit" as const;`
`67`	`67`	`case "API_ERROR":`
`68`		`- return "timeout" as const;`
	`68`	`+ return "server_error" as const;`
`69`	`69`	`default:`
`70`	`70`	`return undefined;`
`71`	`71`	`}`