fix(agents): drop unnecessary non-null assertion in fallback prelude formatter

stainlu · obviyus · commit 2f1c3efe2bff · 2026-04-28T13:31:29.000+05:30
Local default oxlint did not run --type-aware so the warning was missed
on the initial commit; CI surfaced it via check-lint. Hoist the heading
into a named const so its length is read directly without the assertion.
diff --git a/src/agents/command/attempt-execution.helpers.ts b/src/agents/command/attempt-execution.helpers.ts
@@ -237,8 +237,9 @@ export function formatClaudeCliFallbackPrelude(
     CLAUDE_CLI_FALLBACK_PRELUDE_MIN_TURN_CHARS,
     options?.charBudget ?? CLAUDE_CLI_FALLBACK_PRELUDE_DEFAULT_CHAR_BUDGET,
   );
-  const sections: string[] = ["## Prior session context (from claude-cli)"];
-  let remaining = charBudget - sections[0]!.length;
+  const heading = "## Prior session context (from claude-cli)";
+  const sections: string[] = [heading];
+  let remaining = charBudget - heading.length;
   if (seed.summaryText) {
     const summarySection = `\nSummary of earlier conversation:\n${seed.summaryText}`;
     if (summarySection.length <= remaining) {
