fix(hooks): correct resolveHookSource mapping and restore error logging

widingmarcus-cyber · widingmarcus-cyber · commit 2e7972d2de06 · 2026-03-01T19:34:00.000+01:00
- Change "openclaw-plugin" → "workspace" in resolveHookSource so
  plugin-discovered hooks are properly cleared on hot-reload
- Replace silent .catch(() =&gt; {}) with logVerbose in dispatch-unified
  to preserve debug observability for plugin hook failures
diff --git a/src/hooks/dispatch-unified.ts b/src/hooks/dispatch-unified.ts
@@ -6,6 +6,7 @@
  * co-locates the dual dispatch so each call site only needs one function.
  */
 
+import { logVerbose } from "../globals.js";
 import { getGlobalHookRunner } from "../plugins/hook-runner-global.js";
 import { createInternalHookEvent, triggerInternalHook } from "./internal-hooks.js";
 
@@ -42,7 +43,9 @@ export function emitMessageReceived(params: {
           conversationId: params.conversationId,
         },
       )
-      .catch(() => {});
+      .catch((err) => {
+        logVerbose(`dispatch-unified: message_received plugin hook failed: ${String(err)}`);
+      });
   }
 
   if (params.sessionKey) {
@@ -91,7 +94,9 @@ export function emitMessageSent(params: {
           conversationId: params.conversationId ?? params.to,
         },
       )
-      .catch(() => {});
+      .catch((err) => {
+        logVerbose(`dispatch-unified: message_sent plugin hook failed: ${String(err)}`);
+      });
   }
 
   if (params.sessionKey) {
@@ -126,7 +131,11 @@ export function emitGatewayStartup(params: {
   // Plugin hook
   const hookRunner = getGlobalHookRunner();
   if (hookRunner?.hasHooks("gateway_start")) {
-    void hookRunner.runGatewayStart({ port: params.port }, { port: params.port }).catch(() => {});
+    void hookRunner
+      .runGatewayStart({ port: params.port }, { port: params.port })
+      .catch((err) => {
+        logVerbose(`dispatch-unified: gateway_start plugin hook failed: ${String(err)}`);
+      });
   }
 
   // Internal hook — no setTimeout, fire immediately after hooks are loaded
diff --git a/src/hooks/loader.ts b/src/hooks/loader.ts
@@ -25,7 +25,7 @@ function resolveHookSource(source: string): HookSource {
     case "openclaw-bundled": return "bundled";
     case "openclaw-managed": return "managed";
     case "openclaw-workspace": return "workspace";
-    case "openclaw-plugin": return "plugin";
+    case "openclaw-plugin": return "workspace";
     default: return "config";
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ function resolveHookSource(source: string): HookSource {`
`25`	`25`	`case "openclaw-bundled": return "bundled";`
`26`	`26`	`case "openclaw-managed": return "managed";`
`27`	`27`	`case "openclaw-workspace": return "workspace";`
`28`		`- case "openclaw-plugin": return "plugin";`
	`28`	`+ case "openclaw-plugin": return "workspace";`
`29`	`29`	`default: return "config";`
`30`	`30`	`}`
`31`	`31`	`}`