fix(cli): call process.exit(1) in root help and version fast path error handlers (#97793)

maweibin · claude · maweibin · commit 2cfba462f519 · 2026-06-29T22:57:23.000+08:00
The error handler in tryHandleRootHelpFastPath only set process.exitCode=1 without calling process.exit(). When dangling async handles exist (timers, connections, promises), the Node event loop stays open and the CLI hangs indefinitely instead of returning to the terminal. In tryHandleRootVersionFastPath, the default onError handler called process.exit(1) directly, bypassing the injected exit seam that the success path already uses. Changed to exit(1) (deps.exit ?? process.exit) so tests and embedded callers can observe and control exit on failure. Added rejection-path tests for version fast path: injected exit called on resolveVersion rejection, and caller-supplied onError honored. Fixes #97793. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
diff --git a/src/entry.ts b/src/entry.ts
@@ -159,7 +159,7 @@ export async function tryHandleRootHelpFastPath(
         "[openclaw] Failed to display help:",
         error instanceof Error ? (error.stack ?? error.message) : error,
       );
-      process.exitCode = 1;
+      process.exit(1);
     });
   try {
     const loadRootHelpRenderOptionsForConfigSensitivePlugins =
diff --git a/src/entry.version-fast-path.test.ts b/src/entry.version-fast-path.test.ts
@@ -83,4 +83,45 @@ describe("entry root version fast path", () => {
       }),
     ).toBe(false);
   });
+
+  it("calls exit(1) via injected exit hook when resolveVersion rejects", async () => {
+    const exit = vi.fn();
+    const output = vi.fn();
+    const resolveVersion = vi
+      .fn<() => Promise<never>>()
+      .mockRejectedValue(new Error("version resolution failed"));
+
+    expect(
+      tryHandleRootVersionFastPath(["node", "openclaw", "--version"], {
+        output,
+        exit,
+        resolveVersion,
+      }),
+    ).toBe(true);
+    await flushVersionFastPath();
+    expect(resolveVersion).toHaveBeenCalledTimes(1);
+    expect(exit).toHaveBeenCalledWith(1);
+    expect(output).not.toHaveBeenCalled();
+    expect(exit).toHaveBeenCalledTimes(1);
+  });
+
+  it("calls injected onError when provided and resolveVersion rejects", async () => {
+    const exit = vi.fn();
+    const onError = vi.fn();
+    const resolveVersion = vi
+      .fn<() => Promise<never>>()
+      .mockRejectedValue(new Error("version resolution failed"));
+
+    expect(
+      tryHandleRootVersionFastPath(["node", "openclaw", "--version"], {
+        exit,
+        onError,
+        resolveVersion,
+      }),
+    ).toBe(true);
+    await flushVersionFastPath();
+    expect(resolveVersion).toHaveBeenCalledTimes(1);
+    expect(onError).toHaveBeenCalledTimes(1);
+    expect(exit).not.toHaveBeenCalled();
+  });
 });
diff --git a/src/entry.version-fast-path.ts b/src/entry.version-fast-path.ts
@@ -31,7 +31,7 @@ export function tryHandleRootVersionFastPath(
         "[openclaw] Failed to resolve version:",
         error instanceof Error ? (error.stack ?? error.message) : error,
       );
-      process.exitCode = 1;
+      exit(1);
     });
   const resolveVersion =
     deps.resolveVersion ??
