fix(discord): split encoded video URLs from captions (#101815)

VectorPeak · chatgpt-codex-connector[bot] · steipete · web-flow · commit 2cb482dd40ad · 2026-07-09T04:41:53.000+01:00
* fix(discord): split encoded video URLs from captions

Co-authored-by: chatgpt-codex-connector[bot] &lt;199175422+chatgpt-codex-connector[bot]@users.noreply.github.com&gt;

* refactor(discord): scope media filename decoding

---------

Co-authored-by: chatgpt-codex-connector[bot] &lt;199175422+chatgpt-codex-connector[bot]@users.noreply.github.com&gt;
Co-authored-by: Peter Steinberger &lt;steipete@gmail.com&gt;
diff --git a/extensions/discord/src/media-detection.test.ts b/extensions/discord/src/media-detection.test.ts
@@ -0,0 +1,16 @@
+import { describe, expect, it } from "vitest";
+import { isLikelyDiscordVideoMedia } from "./media-detection.js";
+
+describe("isLikelyDiscordVideoMedia", () => {
+  it.each([
+    ["plain local path", "/tmp/render.MP4?download=1", true],
+    ["encoded extension dot", "https://cdn.example/render%2Emp4?download=1", true],
+    ["encoded extension characters", "https://cdn.example/render%2Em%70%34", true],
+    ["malformed earlier segment", "https://cdn.example/bad%ZZ/render%2Emp4", true],
+    ["encoded suffix after extension", "https://cdn.example/render.mp4%2Fpreview", false],
+    ["double-encoded dot", "https://cdn.example/render%252Emp4", false],
+    ["non-video extension", "https://cdn.example/render%2Ejpg", false],
+  ])("classifies %s", (_name, mediaUrl, expected) => {
+    expect(isLikelyDiscordVideoMedia(mediaUrl)).toBe(expected);
+  });
+});
diff --git a/extensions/discord/src/media-detection.ts b/extensions/discord/src/media-detection.ts
@@ -10,7 +10,14 @@ function normalizeMediaPathForExtension(mediaUrl: string): string {
   }
   try {
     const parsed = new URL(trimmed);
-    return normalizeLowercaseStringOrEmpty(parsed.pathname);
+    const fileName = parsed.pathname.slice(parsed.pathname.lastIndexOf("/") + 1);
+    // Mirror media-loader filename decoding without reinterpreting escapes in
+    // earlier URL path segments, which are irrelevant to the file extension.
+    try {
+      return normalizeLowercaseStringOrEmpty(decodeURIComponent(fileName));
+    } catch {
+      return normalizeLowercaseStringOrEmpty(fileName);
+    }
   } catch {
     const withoutHash = trimmed.split("#", 1)[0] ?? trimmed;
     const withoutQuery = withoutHash.split("?", 1)[0] ?? withoutHash;
diff --git a/extensions/discord/src/outbound-adapter.test.ts b/extensions/discord/src/outbound-adapter.test.ts
@@ -588,12 +588,14 @@ describe("discordOutbound", () => {
   it.each([
     {
       name: "implicit first-mode",
+      mediaUrl: "/tmp/render.mp4",
       replyToIdSource: "implicit" as const,
       replyToMode: "first" as const,
       expectedReplies: [{ messageId: "reply-1", scope: "first" }, undefined],
     },
     {
       name: "implicit all-mode",
+      mediaUrl: "/tmp/render.mp4",
       replyToIdSource: "implicit" as const,
       replyToMode: "all" as const,
       expectedReplies: [
@@ -603,6 +605,17 @@ describe("discordOutbound", () => {
     },
     {
       name: "explicit first-mode",
+      mediaUrl: "/tmp/render.mp4",
+      replyToIdSource: "explicit" as const,
+      replyToMode: "first" as const,
+      expectedReplies: [
+        { messageId: "reply-1", scope: "all" },
+        { messageId: "reply-1", scope: "all" },
+      ],
+    },
+    {
+      name: "encoded URL extension",
+      mediaUrl: "https://cdn.discordapp.com/attachments/1/render%2Emp4?ex=1",
       replyToIdSource: "explicit" as const,
       replyToMode: "first" as const,
       expectedReplies: [
@@ -615,7 +628,7 @@ describe("discordOutbound", () => {
       cfg: {},
       to: "channel:123456",
       text: "rendered clip",
-      mediaUrl: "/tmp/render.mp4",
+      mediaUrl: testCase.mediaUrl,
       accountId: "default",
       replyToId: "reply-1",
       replyToIdSource: testCase.replyToIdSource,
@@ -639,7 +652,7 @@ describe("discordOutbound", () => {
     expect(mediaCall[1]).toBe("");
     const mediaOptions = mockObjectArg(hoisted.sendMessageDiscordMock, "sendMessageDiscord", 1, 2);
     expect(mediaOptions.accountId).toBe("default");
-    expect(mediaOptions.mediaUrl).toBe("/tmp/render.mp4");
+    expect(mediaOptions.mediaUrl).toBe(testCase.mediaUrl);
     expect(mediaOptions.reply).toEqual(testCase.expectedReplies[1]);
   });
 
