fix(browser): keep snapshot delta helper private

steipete · steipete · commit 2b9664a158af · 2026-07-25T08:44:15.000-07:00
diff --git a/extensions/browser/src/browser/pw-role-snapshot.test.ts b/extensions/browser/src/browser/pw-role-snapshot.test.ts
@@ -1,7 +1,6 @@
 // Browser tests cover pw role snapshot plugin behavior.
 import { describe, expect, it } from "vitest";
 import {
-  annotateRoleSnapshotDelta,
   buildRoleSnapshotFromAiSnapshot,
   buildRoleSnapshotFromAriaSnapshot,
   finalizeRoleSnapshot,
@@ -137,7 +136,7 @@ describe("pw-role-snapshot", () => {
     const snapshot = '- button "Save" [ref=e1]';
     const refs = { e1: { role: "button", name: "Save" } };
 
-    const result = annotateRoleSnapshotDelta({ snapshot, refs, mode: "role" });
+    const result = finalizeRoleSnapshot({ snapshot, refs, delta: { mode: "role" } });
 
     expect(result.snapshot).toBe(snapshot);
     expect(result.newElements).toBeUndefined();
@@ -152,39 +151,36 @@ describe("pw-role-snapshot", () => {
       e7: { role: "button", name: "Save" },
       e8: { role: "dialog", name: "Confirmation" },
     };
-    const annotated = annotateRoleSnapshotDelta({
+    const finalized = finalizeRoleSnapshot({
       snapshot: ['- button "Save" [ref=e7]', '- dialog "Confirmation" [ref=e8]'].join("\n"),
       refs,
-      mode: "role",
-      previousKeys,
+      delta: { mode: "role", previousKeys },
     });
-    const finalized = finalizeRoleSnapshot({ snapshot: annotated.snapshot, refs });
 
-    expect(annotated.snapshot).toBe(
+    expect(finalized.snapshot).toBe(
       [
         '- button "Save" [ref=e7]',
         '- dialog "Confirmation" [ref=e8] [new]',
         "1 new element(s) since last snapshot",
       ].join("\n"),
     );
-    expect(annotated.newElements).toBe(1);
+    expect(finalized.newElements).toBe(1);
     expect(finalized.refs).toEqual(refs);
   });
 
   it("uses preserved aria refs as AI snapshot identities", () => {
-    const annotated = annotateRoleSnapshotDelta({
+    const finalized = finalizeRoleSnapshot({
       snapshot: ['- button "Save" [ref=7]', '- dialog "Confirmation" [ref=8]'].join("\n"),
       refs: {
         "7": { role: "button", name: "Save" },
         "8": { role: "dialog", name: "Confirmation" },
       },
-      mode: "aria",
-      previousKeys: new Set(["7"]),
+      delta: { mode: "aria", previousKeys: new Set(["7"]) },
     });
 
-    expect(annotated.snapshot).toContain('- button "Save" [ref=7]\n');
-    expect(annotated.snapshot).toContain('- dialog "Confirmation" [ref=8] [new]');
-    expect(annotated.newElements).toBe(1);
+    expect(finalized.snapshot).toContain('- button "Save" [ref=7]\n');
+    expect(finalized.snapshot).toContain('- dialog "Confirmation" [ref=8] [new]');
+    expect(finalized.newElements).toBe(1);
   });
 
   it("annotates before truncation and keeps only complete annotated refs", () => {
diff --git a/extensions/browser/src/browser/pw-role-snapshot.ts b/extensions/browser/src/browser/pw-role-snapshot.ts
@@ -75,7 +75,7 @@ export function getRoleSnapshotIdentityKeys<T extends RoleRef>(
 }
 
 /** Mark ref-bearing lines that were absent from the previous compatible snapshot. */
-export function annotateRoleSnapshotDelta<T extends RoleRef>(params: {
+function annotateRoleSnapshotDelta<T extends RoleRef>(params: {
   snapshot: string;
   refs: Record<string, T>;
   mode: RoleSnapshotIdentityMode;
diff --git a/extensions/browser/src/browser/snapshot-delta-cache.test.ts b/extensions/browser/src/browser/snapshot-delta-cache.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { annotateRoleSnapshotDelta } from "./pw-role-snapshot.js";
+import { finalizeRoleSnapshot } from "./pw-role-snapshot.js";
 import type { BrowserRouteContext } from "./server-context.types.js";
 import {
   getPreviousSnapshotKeys,
@@ -26,11 +26,10 @@ describe("snapshot delta cache", () => {
     });
 
     const previousKeys = getPreviousSnapshotKeys(ctx, cacheScope("pw:document-2"));
-    const snapshot = annotateRoleSnapshotDelta({
+    const snapshot = finalizeRoleSnapshot({
       snapshot: '- button "Continue" [ref=e1]',
       refs: { e1: { role: "button", name: "Continue" } },
-      mode: "role",
-      previousKeys,
+      delta: { mode: "role", previousKeys },
     });
 
     expect(previousKeys).toBeUndefined();
@@ -46,14 +45,13 @@ describe("snapshot delta cache", () => {
       refs: { e1: { role: "button", name: "Save" } },
     });
 
-    const snapshot = annotateRoleSnapshotDelta({
+    const snapshot = finalizeRoleSnapshot({
       snapshot: ['- button "Save" [ref=e7]', '- alert "Required" [ref=e8]'].join("\n"),
       refs: {
         e7: { role: "button", name: "Save" },
         e8: { role: "alert", name: "Required" },
       },
-      mode: "role",
-      previousKeys: getPreviousSnapshotKeys(ctx, scope),
+      delta: { mode: "role", previousKeys: getPreviousSnapshotKeys(ctx, scope) },
     });
 
     expect(snapshot.snapshot).toContain('- alert "Required" [ref=e8] [new]');

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export function getRoleSnapshotIdentityKeys<T extends RoleRef>(`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`/** Mark ref-bearing lines that were absent from the previous compatible snapshot. */`
`78`		`-export function annotateRoleSnapshotDelta<T extends RoleRef>(params: {`
	`78`	`+function annotateRoleSnapshotDelta<T extends RoleRef>(params: {`
`79`	`79`	`snapshot: string;`
`80`	`80`	`refs: Record<string, T>;`
`81`	`81`	`mode: RoleSnapshotIdentityMode;`