You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .agents/skills/autoreview/SKILL.md
+10-9Lines changed: 10 additions & 9 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -23,10 +23,11 @@ Use when:
23
23
- Prefer small fixes at the right ownership boundary; no refactor unless it clearly improves the bug class.
24
24
- Keep going until the selected review path returns no accepted/actionable findings.
25
25
- If a review-triggered fix changes code, rerun focused tests and rerun the review helper.
26
-
- Default to Codex review. If Codex is unavailable or exits with an error, the helper falls back to the first configured CLI from `claude -p`, `pi -p`, `opencode run`, `droid exec`, or `copilot`. Prefer Codex for final closeout because it uses native review mode; non-Codex reviewers use a Codex-inspired generated diff prompt. The helper runs nested Codex review in yolo/full-access mode by default; use `--no-yolo` only when intentionally testing sandbox behavior.
26
+
- Default to Codex reviewwith no fallback. Prefer Codex for final closeout because it uses native review mode; non-Codex reviewers use a Codex-inspired generated diff prompt. Use `--fallback-reviewer auto|claude|pi|opencode|droid|copilot` only when a second-model fallback is explicitly wanted and authenticated. The helper runs nested Codex review in yolo/full-access mode by default; use `--no-yolo` only when intentionally testing sandbox behavior.
27
27
- Stop as soon as the review command/helper exits 0 with no accepted/actionable findings. Do not run an extra direct `codex review` just to get a nicer "clean" line, a second opinion, or clearer closeout wording.
28
28
- Treat the helper's successful exit plus absence of actionable findings as the clean review result, even if the underlying Codex CLI output is terse.
29
29
- If rejecting a finding as intentional/not worth fixing, add a brief inline code comment only when it explains a real invariant or ownership decision that future reviewers should know.
30
+
- If creating or updating a PR while rejecting any autoreview finding, record the rejected finding and reason in the PR description so later reviewers can distinguish intentional design decisions from missed review output.
30
31
- Do not push just to review. Push only when the user requested push/ship/PR update.
31
32
- For OpenClaw maintainers, keep autoreview validation Crabbox/Testbox-aware when maintainer validation mode is enabled (`OPENCLAW_TESTBOX=1` or `AUTOREVIEW_OPENCLAW_MAINTAINER_VALIDATION=1`). A review pass may inspect files and run cheap non-Node probes, but it must not start local `pnpm`, Vitest, `tsgo`, `npm test`, or `node scripts/run-vitest.mjs` from a Codex/worktree review unless the operator explicitly requested local proof. For runtime proof, use existing evidence or route through Crabbox/Testbox and report the id. Do not apply this rule to ordinary contributors who do not have maintainer Testbox access.
32
33
@@ -51,11 +52,11 @@ git fetch origin
51
52
codex review --base origin/main
52
53
```
53
54
54
-
Do not pass any prompt with `--base`. Some Codex CLI versions reject both inline
55
-
and stdin prompt forms, including the helper's `codex review --base <ref> -`,
56
-
with `--base <BRANCH> cannot be used with [PROMPT]`. If the helper hits this
57
-
error, run plain `codex review --base <ref>` and report that the helper prompt
58
-
injection was skipped.
55
+
Do not pass any prompt with `--base`, `--commit`, or `--uncommitted`. Codex CLI
56
+
review targets and custom review prompts are mutually exclusive: target modes
57
+
generate their own review prompt internally. Use plain target review for native
58
+
Codex closeout, or use custom prompt review (`codex review -`) only when you
59
+
intentionally want a generated diff prompt instead of native target review.
59
60
60
61
If an open PR exists, use its actual base:
61
62
@@ -116,13 +117,13 @@ The helper:
116
117
- use `--mode commit --commit <ref>` for already-committed work, especially clean `main` after landing
117
118
- should be left in `--mode auto` or forced to `--mode branch` for PR/branch work; do not force `--mode local` after committing
118
119
- supports `--reviewer codex|claude|pi|opencode|droid|copilot|auto`; `auto` means Codex first
119
-
- supports `--fallback-reviewer auto|claude|pi|opencode|droid|copilot|none`; default is configured CLI fallback
120
+
- supports `--fallback-reviewer auto|claude|pi|opencode|droid|copilot|none`; default is `none`
120
121
- falls back only when Codex is unavailable or exits nonzero, not when Codex reports findings
121
122
- writes only to stdout unless `--output` or `AUTOREVIEW_OUTPUT` is set
122
123
- supports `--dry-run`, `--parallel-tests`, and commit refs
123
124
- runs nested review with `--dangerously-bypass-approvals-and-sandbox --sandbox danger-full-access` by default
124
-
-injects maintainer-only OpenClaw validation policy into native Codex review when `OPENCLAW_TESTBOX=1` or `AUTOREVIEW_OPENCLAW_MAINTAINER_VALIDATION=1`, so local memory-heavy Node/Vitest checks are avoided in favor of Crabbox/Testbox proof
125
-
-branch mode may fail on Codex CLI versions that reject `--base` plus the helper's stdin prompt; on that exact parser error, rerun plain `codex review --base <ref>` instead of falling back to a non-Codex reviewer
125
+
-with `OPENCLAW_TESTBOX=1` or `AUTOREVIEW_OPENCLAW_MAINTAINER_VALIDATION=1`, disables auto local `pnpm run check` and routes Codex through generated prompt review (`codex review -`) so the no-local-heavy-tests policy is included; native Codex target review cannot accept extra prompt text
126
+
-non-Codex reviewers receive the generated diff prompt and maintainer validation policy text when maintainer validation is active
126
127
- keeps accepting `--full-access`; use `--no-yolo` or `AUTOREVIEW_YOLO=0` to opt out
127
128
- still accepts legacy `CODEX_REVIEW_*` env vars when the matching `AUTOREVIEW_*` var is unset
128
129
- prints `autoreview clean: no accepted/actionable findings reported` when the selected review command exits 0
Copy file name to clipboardExpand all lines: .agents/skills/openclaw-release-ci/SKILL.md
+4-1Lines changed: 4 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -28,7 +28,10 @@ git status --short --branch
28
28
git rev-parse HEAD
29
29
```
30
30
31
-
If env lacks keys, use `$one-password` to inject or set them, then rerun the script. The script prints only provider status and HTTP class, never tokens.
31
+
1Password service-account values are the first source for release provider
32
+
preflight. Inject those exact targeted keys first, then run the verifier; use
33
+
ambient env only when it was already intentionally injected for this release.
34
+
The script prints only provider status and HTTP class, never tokens.
0 commit comments