fix(session-memory): reset mirror dedupe on command turns

sallyom · sallyom · commit 28cbe0024711 · 2026-06-29T09:24:28.000-04:00
Signed-off-by: sallyom &lt;somalley@redhat.com&gt;
diff --git a/src/hooks/bundled/session-memory/handler.test.ts b/src/hooks/bundled/session-memory/handler.test.ts
@@ -942,4 +942,40 @@ describe("session-memory hook", () => {
       "assistant: Your number is 123-4567",
     ]);
   });
+
+  it("preserves delivery-mirror after an omitted slash-command user turn", async () => {
+    const sessionContent = [
+      JSON.stringify({
+        type: "message",
+        message: { role: "assistant", content: "Done" },
+      }),
+      JSON.stringify({
+        type: "message",
+        message: {
+          role: "assistant",
+          provider: "openclaw",
+          model: "delivery-mirror",
+          content: [{ type: "text", text: "Done" }],
+        },
+      }),
+      JSON.stringify({
+        type: "message",
+        message: { role: "user", content: "/new" },
+      }),
+      JSON.stringify({
+        type: "message",
+        message: {
+          role: "assistant",
+          provider: "openclaw",
+          model: "delivery-mirror",
+          content: [{ type: "text", text: "Done" }],
+        },
+      }),
+    ].join("\n");
+
+    const memoryContent = await readSessionTranscript({ sessionContent });
+    const lines = memoryContent!.split("\n").filter((l) => l.startsWith("assistant:"));
+    expect(lines).toEqual(["assistant: Done", "assistant: Done"]);
+    expect(memoryContent).not.toContain("user: /new");
+  });
 });
diff --git a/src/hooks/bundled/session-memory/transcript.ts b/src/hooks/bundled/session-memory/transcript.ts
@@ -80,6 +80,11 @@ export async function getRecentSessionContent(
             if (role === "user" && hasInterSessionUserProvenance(msg)) {
               continue;
             }
+            if (role === "user") {
+              // New turn: reset even when slash commands are omitted from
+              // memory, so later standalone delivery mirrors are preserved.
+              lastAssistantText = undefined;
+            }
             const text = extractTextMessageContent(msg.content);
             const sanitized = text ? sanitizeSessionMemoryTranscriptText(text) : null;
             // Skip delivery-mirror rows only when they duplicate the preceding
@@ -94,10 +99,6 @@ export async function getRecentSessionContent(
               allMessages.push(`${role}: ${sanitized}`);
               if (role === "assistant") {
                 lastAssistantText = sanitized;
-              } else if (role === "user") {
-                // New turn: reset so a delivery-mirror echoing the previous
-                // turn's assistant text isn't silently filtered.
-                lastAssistantText = undefined;
               }
             }
           }

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,11 @@ export async function getRecentSessionContent(`
`80`	`80`	`if (role === "user" && hasInterSessionUserProvenance(msg)) {`
`81`	`81`	`continue;`
`82`	`82`	`}`
	`83`	`+ if (role === "user") {`
	`84`	`+ // New turn: reset even when slash commands are omitted from`
	`85`	`+ // memory, so later standalone delivery mirrors are preserved.`
	`86`	`+ lastAssistantText = undefined;`
	`87`	`+ }`
`83`	`88`	`const text = extractTextMessageContent(msg.content);`
`84`	`89`	`const sanitized = text ? sanitizeSessionMemoryTranscriptText(text) : null;`
`85`	`90`	`// Skip delivery-mirror rows only when they duplicate the preceding`
`@@ -94,10 +99,6 @@ export async function getRecentSessionContent(`
`94`	`99`	allMessages.push(`${role}: ${sanitized}`);
`95`	`100`	`if (role === "assistant") {`
`96`	`101`	`lastAssistantText = sanitized;`
`97`		`- } else if (role === "user") {`
`98`		`- // New turn: reset so a delivery-mirror echoing the previous`
`99`		`- // turn's assistant text isn't silently filtered.`
`100`		`- lastAssistantText = undefined;`
`101`	`102`	`}`
`102`	`103`	`}`
`103`	`104`	`}`