fix(infra): register no-op error handler on detached gateway spawn child

chenxiaoyu209 · chenxiaoyu209 · commit 26a20695902e · 2026-07-07T16:17:02.000+08:00
diff --git a/src/infra/process-respawn.test.ts b/src/infra/process-respawn.test.ts
@@ -302,7 +302,7 @@ describe("respawnGatewayProcessForUpdate", () => {
       "gateway",
       "run",
     ];
-    spawnMock.mockReturnValue({ pid: 5151, unref: vi.fn(), kill: vi.fn() });
+    spawnMock.mockReturnValue({ pid: 5151, unref: vi.fn(), kill: vi.fn(), on: vi.fn() });
 
     const result = respawnGatewayProcessForUpdate();
 
@@ -329,7 +329,7 @@ describe("respawnGatewayProcessForUpdate", () => {
       "gateway",
       "run",
     ];
-    spawnMock.mockReturnValue({ pid: 7171, unref: vi.fn(), kill: vi.fn() });
+    spawnMock.mockReturnValue({ pid: 7171, unref: vi.fn(), kill: vi.fn(), on: vi.fn() });
 
     const result = respawnGatewayProcessForUpdate();
 
@@ -352,7 +352,7 @@ describe("respawnGatewayProcessForUpdate", () => {
     const entry =
       "/app/node_modules/.pnpm/@anthropic+sdk@1.0.0/node_modules/@anthropic/sdk/dist/index.js";
     process.argv = ["/usr/local/bin/node", entry, "gateway", "run"];
-    spawnMock.mockReturnValue({ pid: 8181, unref: vi.fn(), kill: vi.fn() });
+    spawnMock.mockReturnValue({ pid: 8181, unref: vi.fn(), kill: vi.fn(), on: vi.fn() });
 
     respawnGatewayProcessForUpdate();
 
@@ -369,7 +369,7 @@ describe("respawnGatewayProcessForUpdate", () => {
     process.env.XPC_SERVICE_NAME = "ai.openclaw.mac";
     process.execArgv = [];
     process.argv = ["/usr/local/bin/node", "/repo/dist/index.js", "gateway", "run"];
-    spawnMock.mockReturnValue({ pid: 6161, unref: vi.fn(), kill: vi.fn() });
+    spawnMock.mockReturnValue({ pid: 6161, unref: vi.fn(), kill: vi.fn(), on: vi.fn() });
 
     const result = respawnGatewayProcessForUpdate();
 
@@ -413,4 +413,27 @@ describe("respawnGatewayProcessForUpdate", () => {
     expect(result.mode).toBe("failed");
     expect(result.detail).toContain("spawn failed");
   });
+
+  it("registers a no-op error listener on the detached child to prevent unhandled async errors", () => {
+    delete process.env.OPENCLAW_NO_RESPAWN;
+    clearSupervisorHints();
+    setPlatform("linux");
+
+    const onMock = vi.fn();
+    spawnMock.mockReturnValue({
+      pid: 9091,
+      unref: vi.fn(),
+      kill: vi.fn(),
+      on: onMock,
+    });
+
+    const result = respawnGatewayProcessForUpdate();
+
+    expect(result.mode).toBe("spawned");
+    expect(onMock).toHaveBeenCalledWith("error", expect.any(Function));
+
+    const errorHandler = onMock.mock.calls[0]?.[1] as (...args: unknown[]) => void;
+    expect(() => errorHandler(new Error("ENOMEM"))).not.toThrow();
+    expect(() => errorHandler(new Error("spawn EBADF"))).not.toThrow();
+  });
 });
diff --git a/src/infra/process-respawn.ts b/src/infra/process-respawn.ts
@@ -53,6 +53,7 @@ function spawnDetachedGatewayProcess(opts: GatewayRespawnOptions = {}): {
     detached: true,
     stdio: "inherit",
   });
+  child.on("error", () => {});
   child.unref();
   return { child, pid: child.pid ?? undefined };
 }

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ function spawnDetachedGatewayProcess(opts: GatewayRespawnOptions = {}): {`
`53`	`53`	`detached: true,`
`54`	`54`	`stdio: "inherit",`
`55`	`55`	`});`
	`56`	`+ child.on("error", () => {});`
`56`	`57`	`child.unref();`
`57`	`58`	`return { child, pid: child.pid ?? undefined };`
`58`	`59`	`}`