fix: resolve extension type errors and harden probe mocks

steipete · steipete · commit 26763d191015 · 2026-02-22T12:25:58.000+01:00
diff --git a/extensions/bluebubbles/src/runtime.ts b/extensions/bluebubbles/src/runtime.ts
@@ -1,6 +1,7 @@
 import type { PluginRuntime } from "openclaw/plugin-sdk";
 
 let runtime: PluginRuntime | null = null;
+type LegacyRuntimeLogShape = { log?: (message: string) => void };
 
 export function setBlueBubblesRuntime(next: PluginRuntime): void {
   runtime = next;
@@ -23,7 +24,8 @@ export function getBlueBubblesRuntime(): PluginRuntime {
 
 export function warnBlueBubbles(message: string): void {
   const formatted = `[bluebubbles] ${message}`;
-  const log = runtime?.log;
+  // Backward-compatible with tests/legacy injections that pass { log }.
+  const log = (runtime as unknown as LegacyRuntimeLogShape | null)?.log;
   if (typeof log === "function") {
     log(formatted);
     return;
diff --git a/extensions/bluebubbles/src/test-harness.ts b/extensions/bluebubbles/src/test-harness.ts
@@ -2,10 +2,10 @@ import type { Mock } from "vitest";
 import { afterEach, beforeEach, vi } from "vitest";
 
 export const BLUE_BUBBLES_PRIVATE_API_STATUS = {
-  enabled: true as const,
-  disabled: false as const,
-  unknown: null as const,
-};
+  enabled: true,
+  disabled: false,
+  unknown: null,
+} as const;
 
 type BlueBubblesPrivateApiStatusMock = {
   mockReturnValue: (value: boolean | null) => unknown;
@@ -47,13 +47,15 @@ export function createBlueBubblesAccountsMockModule() {
 
 type BlueBubblesProbeMockModule = {
   getCachedBlueBubblesPrivateApiStatus: Mock<() => boolean | null>;
+  isBlueBubblesPrivateApiStatusEnabled: Mock<(status: boolean | null) => boolean>;
 };
 
 export function createBlueBubblesProbeMockModule(): BlueBubblesProbeMockModule {
   return {
     getCachedBlueBubblesPrivateApiStatus: vi
       .fn()
       .mockReturnValue(BLUE_BUBBLES_PRIVATE_API_STATUS.unknown),
+    isBlueBubblesPrivateApiStatusEnabled: vi.fn((status: boolean | null) => status === true),
   };
 }
 
diff --git a/extensions/feishu/src/channel.ts b/extensions/feishu/src/channel.ts
@@ -225,9 +225,7 @@ export const feishuPlugin: ChannelPlugin<ResolvedFeishuAccount> = {
     collectWarnings: ({ cfg, accountId }) => {
       const account = resolveFeishuAccount({ cfg, accountId });
       const feishuCfg = account.config;
-      const defaultGroupPolicy = (
-        cfg.channels as Record<string, { groupPolicy?: string }> | undefined
-      )?.defaults?.groupPolicy;
+      const defaultGroupPolicy = cfg.channels?.defaults?.groupPolicy;
       const { groupPolicy } = resolveRuntimeGroupPolicy({
         providerConfigPresent: cfg.channels?.feishu !== undefined,
         groupPolicy: feishuCfg?.groupPolicy,
diff --git a/extensions/line/src/channel.ts b/extensions/line/src/channel.ts
@@ -162,8 +162,7 @@ export const linePlugin: ChannelPlugin<ResolvedLineAccount> = {
       };
     },
     collectWarnings: ({ account, cfg }) => {
-      const defaultGroupPolicy = (cfg.channels?.defaults as { groupPolicy?: string } | undefined)
-        ?.groupPolicy;
+      const defaultGroupPolicy = cfg.channels?.defaults?.groupPolicy;
       const { groupPolicy } = resolveRuntimeGroupPolicy({
         providerConfigPresent: cfg.channels?.line !== undefined,
         groupPolicy: account.config.groupPolicy,
