fix: document agent cleanup catch intent

ZengWen-DT · ZengWen-DT · commit 259eda62af06 · 2026-06-29T06:58:09.000Z
diff --git a/src/agents/minimax-vlm.ts b/src/agents/minimax-vlm.ts
@@ -54,7 +54,10 @@ function coerceApiHost(params: {
   try {
     const url = new URL(raw);
     return url.origin;
-  } catch {}
+  } catch {
+    // Bare hosts are retried with https:// below; malformed absolute URLs fall
+    // back to provider defaults instead of sending requests to invalid endpoints.
+  }
 
   if (/^[a-z][a-z\d+.-]*:\/\//i.test(raw)) {
     return defaultHost;
diff --git a/src/agents/provider-http-errors.ts b/src/agents/provider-http-errors.ts
@@ -81,7 +81,10 @@ export async function readResponseTextLimited(
     }
     try {
       reader.releaseLock();
-    } catch {}
+    } catch {
+      // Error-body reads are diagnostic best effort; release failures must not
+      // hide the bounded provider error text already captured.
+    }
   }
 
   return text;
diff --git a/src/agents/runtime/proxy.ts b/src/agents/runtime/proxy.ts
@@ -409,7 +409,10 @@ export function streamProxy(
     } finally {
       try {
         reader?.releaseLock();
-      } catch {}
+      } catch {
+        // Stream handling above already pushed the terminal proxy event;
+        // cleanup failures must not replace it with a secondary release error.
+      }
       if (options.signal) {
         options.signal.removeEventListener("abort", abortHandler);
       }
diff --git a/src/agents/tools/web-shared.ts b/src/agents/tools/web-shared.ts
@@ -287,7 +287,10 @@ export async function readResponseText(
       }
       try {
         reader.releaseLock();
-      } catch {}
+      } catch {
+        // The read/cancel path already produced the best-effort body result;
+        // lock-release failures must not replace that outcome.
+      }
     }
 
     const bytes = concatBytes(parts, bytesRead);

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,10 @@ export async function readResponseTextLimited(`
`81`	`81`	`}`
`82`	`82`	`try {`
`83`	`83`	`reader.releaseLock();`
`84`		`- } catch {}`
	`84`	`+ } catch {`
	`85`	`+ // Error-body reads are diagnostic best effort; release failures must not`
	`86`	`+ // hide the bounded provider error text already captured.`
	`87`	`+ }`
`85`	`88`	`}`
`86`	`89`
`87`	`90`	`return text;`
Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,10 @@ export async function readResponseText(`
`287`	`287`	`}`
`288`	`288`	`try {`
`289`	`289`	`reader.releaseLock();`
`290`		`- } catch {}`
	`290`	`+ } catch {`
	`291`	`+ // The read/cancel path already produced the best-effort body result;`
	`292`	`+ // lock-release failures must not replace that outcome.`
	`293`	`+ }`
`291`	`294`	`}`
`292`	`295`
`293`	`296`	`const bytes = concatBytes(parts, bytesRead);`