|
| 1 | +import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; |
| 2 | +import { emitAgentEvent } from "../infra/agent-events.js"; |
| 3 | +import { |
| 4 | + resolveAcpSpawnStreamLogPath, |
| 5 | + startAcpSpawnParentStreamRelay, |
| 6 | +} from "./acp-spawn-parent-stream.js"; |
| 7 | + |
| 8 | +const enqueueSystemEventMock = vi.fn(); |
| 9 | +const requestHeartbeatNowMock = vi.fn(); |
| 10 | +const readAcpSessionEntryMock = vi.fn(); |
| 11 | +const resolveSessionFilePathMock = vi.fn(); |
| 12 | +const resolveSessionFilePathOptionsMock = vi.fn(); |
| 13 | + |
| 14 | +vi.mock("../infra/system-events.js", () => ({ |
| 15 | + enqueueSystemEvent: (...args: unknown[]) => enqueueSystemEventMock(...args), |
| 16 | +})); |
| 17 | + |
| 18 | +vi.mock("../infra/heartbeat-wake.js", () => ({ |
| 19 | + requestHeartbeatNow: (...args: unknown[]) => requestHeartbeatNowMock(...args), |
| 20 | +})); |
| 21 | + |
| 22 | +vi.mock("../acp/runtime/session-meta.js", () => ({ |
| 23 | + readAcpSessionEntry: (...args: unknown[]) => readAcpSessionEntryMock(...args), |
| 24 | +})); |
| 25 | + |
| 26 | +vi.mock("../config/sessions/paths.js", () => ({ |
| 27 | + resolveSessionFilePath: (...args: unknown[]) => resolveSessionFilePathMock(...args), |
| 28 | + resolveSessionFilePathOptions: (...args: unknown[]) => resolveSessionFilePathOptionsMock(...args), |
| 29 | +})); |
| 30 | + |
| 31 | +function collectedTexts() { |
| 32 | + return enqueueSystemEventMock.mock.calls.map((call) => String(call[0] ?? "")); |
| 33 | +} |
| 34 | + |
| 35 | +describe("startAcpSpawnParentStreamRelay", () => { |
| 36 | + beforeEach(() => { |
| 37 | + enqueueSystemEventMock.mockClear(); |
| 38 | + requestHeartbeatNowMock.mockClear(); |
| 39 | + readAcpSessionEntryMock.mockReset(); |
| 40 | + resolveSessionFilePathMock.mockReset(); |
| 41 | + resolveSessionFilePathOptionsMock.mockReset(); |
| 42 | + resolveSessionFilePathOptionsMock.mockImplementation((value: unknown) => value); |
| 43 | + vi.useFakeTimers(); |
| 44 | + vi.setSystemTime(new Date("2026-03-04T01:00:00.000Z")); |
| 45 | + }); |
| 46 | + |
| 47 | + afterEach(() => { |
| 48 | + vi.useRealTimers(); |
| 49 | + }); |
| 50 | + |
| 51 | + it("relays assistant progress and completion to the parent session", () => { |
| 52 | + const relay = startAcpSpawnParentStreamRelay({ |
| 53 | + runId: "run-1", |
| 54 | + parentSessionKey: "agent:main:main", |
| 55 | + childSessionKey: "agent:codex:acp:child-1", |
| 56 | + agentId: "codex", |
| 57 | + streamFlushMs: 10, |
| 58 | + noOutputNoticeMs: 120_000, |
| 59 | + }); |
| 60 | + |
| 61 | + emitAgentEvent({ |
| 62 | + runId: "run-1", |
| 63 | + stream: "assistant", |
| 64 | + data: { |
| 65 | + delta: "hello from child", |
| 66 | + }, |
| 67 | + }); |
| 68 | + vi.advanceTimersByTime(15); |
| 69 | + |
| 70 | + emitAgentEvent({ |
| 71 | + runId: "run-1", |
| 72 | + stream: "lifecycle", |
| 73 | + data: { |
| 74 | + phase: "end", |
| 75 | + startedAt: 1_000, |
| 76 | + endedAt: 3_100, |
| 77 | + }, |
| 78 | + }); |
| 79 | + |
| 80 | + const texts = collectedTexts(); |
| 81 | + expect(texts.some((text) => text.includes("Started codex session"))).toBe(true); |
| 82 | + expect(texts.some((text) => text.includes("codex: hello from child"))).toBe(true); |
| 83 | + expect(texts.some((text) => text.includes("codex run completed in 2s"))).toBe(true); |
| 84 | + expect(requestHeartbeatNowMock).toHaveBeenCalledWith( |
| 85 | + expect.objectContaining({ |
| 86 | + reason: "acp:spawn:stream", |
| 87 | + sessionKey: "agent:main:main", |
| 88 | + }), |
| 89 | + ); |
| 90 | + relay.dispose(); |
| 91 | + }); |
| 92 | + |
| 93 | + it("emits a no-output notice and a resumed notice when output returns", () => { |
| 94 | + const relay = startAcpSpawnParentStreamRelay({ |
| 95 | + runId: "run-2", |
| 96 | + parentSessionKey: "agent:main:main", |
| 97 | + childSessionKey: "agent:codex:acp:child-2", |
| 98 | + agentId: "codex", |
| 99 | + streamFlushMs: 1, |
| 100 | + noOutputNoticeMs: 1_000, |
| 101 | + noOutputPollMs: 250, |
| 102 | + }); |
| 103 | + |
| 104 | + vi.advanceTimersByTime(1_500); |
| 105 | + expect(collectedTexts().some((text) => text.includes("has produced no output for 1s"))).toBe( |
| 106 | + true, |
| 107 | + ); |
| 108 | + |
| 109 | + emitAgentEvent({ |
| 110 | + runId: "run-2", |
| 111 | + stream: "assistant", |
| 112 | + data: { |
| 113 | + delta: "resumed output", |
| 114 | + }, |
| 115 | + }); |
| 116 | + vi.advanceTimersByTime(5); |
| 117 | + |
| 118 | + const texts = collectedTexts(); |
| 119 | + expect(texts.some((text) => text.includes("resumed output."))).toBe(true); |
| 120 | + expect(texts.some((text) => text.includes("codex: resumed output"))).toBe(true); |
| 121 | + |
| 122 | + emitAgentEvent({ |
| 123 | + runId: "run-2", |
| 124 | + stream: "lifecycle", |
| 125 | + data: { |
| 126 | + phase: "error", |
| 127 | + error: "boom", |
| 128 | + }, |
| 129 | + }); |
| 130 | + expect(collectedTexts().some((text) => text.includes("run failed: boom"))).toBe(true); |
| 131 | + relay.dispose(); |
| 132 | + }); |
| 133 | + |
| 134 | + it("auto-disposes stale relays after max lifetime timeout", () => { |
| 135 | + const relay = startAcpSpawnParentStreamRelay({ |
| 136 | + runId: "run-3", |
| 137 | + parentSessionKey: "agent:main:main", |
| 138 | + childSessionKey: "agent:codex:acp:child-3", |
| 139 | + agentId: "codex", |
| 140 | + streamFlushMs: 1, |
| 141 | + noOutputNoticeMs: 0, |
| 142 | + maxRelayLifetimeMs: 1_000, |
| 143 | + }); |
| 144 | + |
| 145 | + vi.advanceTimersByTime(1_001); |
| 146 | + expect(collectedTexts().some((text) => text.includes("stream relay timed out after 1s"))).toBe( |
| 147 | + true, |
| 148 | + ); |
| 149 | + |
| 150 | + const before = enqueueSystemEventMock.mock.calls.length; |
| 151 | + emitAgentEvent({ |
| 152 | + runId: "run-3", |
| 153 | + stream: "assistant", |
| 154 | + data: { |
| 155 | + delta: "late output", |
| 156 | + }, |
| 157 | + }); |
| 158 | + vi.advanceTimersByTime(5); |
| 159 | + |
| 160 | + expect(enqueueSystemEventMock.mock.calls).toHaveLength(before); |
| 161 | + relay.dispose(); |
| 162 | + }); |
| 163 | + |
| 164 | + it("supports delayed start notices", () => { |
| 165 | + const relay = startAcpSpawnParentStreamRelay({ |
| 166 | + runId: "run-4", |
| 167 | + parentSessionKey: "agent:main:main", |
| 168 | + childSessionKey: "agent:codex:acp:child-4", |
| 169 | + agentId: "codex", |
| 170 | + emitStartNotice: false, |
| 171 | + }); |
| 172 | + |
| 173 | + expect(collectedTexts().some((text) => text.includes("Started codex session"))).toBe(false); |
| 174 | + |
| 175 | + relay.notifyStarted(); |
| 176 | + |
| 177 | + expect(collectedTexts().some((text) => text.includes("Started codex session"))).toBe(true); |
| 178 | + relay.dispose(); |
| 179 | + }); |
| 180 | + |
| 181 | + it("preserves delta whitespace boundaries in progress relays", () => { |
| 182 | + const relay = startAcpSpawnParentStreamRelay({ |
| 183 | + runId: "run-5", |
| 184 | + parentSessionKey: "agent:main:main", |
| 185 | + childSessionKey: "agent:codex:acp:child-5", |
| 186 | + agentId: "codex", |
| 187 | + streamFlushMs: 10, |
| 188 | + noOutputNoticeMs: 120_000, |
| 189 | + }); |
| 190 | + |
| 191 | + emitAgentEvent({ |
| 192 | + runId: "run-5", |
| 193 | + stream: "assistant", |
| 194 | + data: { |
| 195 | + delta: "hello", |
| 196 | + }, |
| 197 | + }); |
| 198 | + emitAgentEvent({ |
| 199 | + runId: "run-5", |
| 200 | + stream: "assistant", |
| 201 | + data: { |
| 202 | + delta: " world", |
| 203 | + }, |
| 204 | + }); |
| 205 | + vi.advanceTimersByTime(15); |
| 206 | + |
| 207 | + const texts = collectedTexts(); |
| 208 | + expect(texts.some((text) => text.includes("codex: hello world"))).toBe(true); |
| 209 | + relay.dispose(); |
| 210 | + }); |
| 211 | + |
| 212 | + it("resolves ACP spawn stream log path from session metadata", () => { |
| 213 | + readAcpSessionEntryMock.mockReturnValue({ |
| 214 | + storePath: "/tmp/openclaw/agents/codex/sessions/sessions.json", |
| 215 | + entry: { |
| 216 | + sessionId: "sess-123", |
| 217 | + sessionFile: "/tmp/openclaw/agents/codex/sessions/sess-123.jsonl", |
| 218 | + }, |
| 219 | + }); |
| 220 | + resolveSessionFilePathMock.mockReturnValue( |
| 221 | + "/tmp/openclaw/agents/codex/sessions/sess-123.jsonl", |
| 222 | + ); |
| 223 | + |
| 224 | + const resolved = resolveAcpSpawnStreamLogPath({ |
| 225 | + childSessionKey: "agent:codex:acp:child-1", |
| 226 | + }); |
| 227 | + |
| 228 | + expect(resolved).toBe("/tmp/openclaw/agents/codex/sessions/sess-123.acp-stream.jsonl"); |
| 229 | + expect(readAcpSessionEntryMock).toHaveBeenCalledWith({ |
| 230 | + sessionKey: "agent:codex:acp:child-1", |
| 231 | + }); |
| 232 | + expect(resolveSessionFilePathMock).toHaveBeenCalledWith( |
| 233 | + "sess-123", |
| 234 | + expect.objectContaining({ |
| 235 | + sessionId: "sess-123", |
| 236 | + }), |
| 237 | + expect.objectContaining({ |
| 238 | + storePath: "/tmp/openclaw/agents/codex/sessions/sessions.json", |
| 239 | + }), |
| 240 | + ); |
| 241 | + }); |
| 242 | +}); |
0 commit comments