fix(memory): backfill provider.model with resolved model name

hailory · xydt-tanshanshan · commit 250cfe9e241b · 2026-07-17T16:19:10.000+08:00
When an adapter returns an empty provider.model, set it to the resolved model name from resolveProviderModel. Uses direct property assignment instead of spread to preserve prototype-defined methods on plugin provider objects (P1 finding). Prevents downstream identity mismatches and broken vector search (issue #90042). Supersedes #91660 (31 days old, merge conflicts).
diff --git a/extensions/memory-core/src/memory/embeddings.test.ts b/extensions/memory-core/src/memory/embeddings.test.ts
@@ -313,4 +313,23 @@ describe("createEmbeddingProvider", () => {
     expect(model).toBe("generic-default");
     expect(mockEmbeddingRegistry.genericLookupConfigs).toEqual([options.config]);
   });
+
+  it("backfills empty provider.model with resolved model name (#90042)", async () => {
+    registerMemoryEmbeddingProvider({
+      id: "openai",
+      transport: "remote",
+      defaultModel: "text-embedding-3-small",
+      create: async () => ({
+        provider: {
+          id: "openai",
+          model: "",
+          embedQuery: async () => [1],
+          embedBatch: async (texts) => texts.map(() => [1]),
+        },
+      }),
+    });
+
+    const result = await createEmbeddingProvider(createOptions("openai"));
+    expect(result.provider?.model).toBe("text-embedding-3-small");
+  });
 });
diff --git a/extensions/memory-core/src/memory/embeddings.ts b/extensions/memory-core/src/memory/embeddings.ts
@@ -242,6 +242,9 @@ async function createWithAdapter(
     model: resolveProviderModel(adapter, options.model),
   };
   const result = await adapter.create(createOptions);
+  if (result.provider && !result.provider.model) {
+    result.provider.model = createOptions.model;
+  }
   return {
     provider: result.provider,
     requestedProvider: options.provider,
