refactor(cron): centralize silent reply policy

steipete · LZY3538 · steipete · commit 2330c6be13cc · 2026-07-11T14:43:05.000+01:00
Reuse existing executor suites and keep CLI and embedded cron runners aligned.

Co-authored-by: 刘镇业 0668001127 &lt;liu.zhenye@xydigit.com&gt;
diff --git a/src/cron/isolated-agent/run-executor.silent-empty.test.ts b/src/cron/isolated-agent/run-executor.silent-empty.test.ts
diff --git a/src/cron/isolated-agent/run-executor.ts b/src/cron/isolated-agent/run-executor.ts
@@ -277,6 +277,8 @@ export function createCronPromptExecutor(params: {
     resolveFallbackCronSourceDeliveryPlan(params.job, params.resolvedDelivery);
   const sourceReplyDeliveryMode = sourceDelivery.sourceReplyDeliveryMode;
   const messageChannel = sourceDelivery.target.channel ?? params.resolvedDelivery.channel;
+  // Cron prompts may intentionally have nothing to report; both runners must agree on silence.
+  const allowEmptyAssistantReplyAsSilent = true;
   const deliveryTargetRuntimeContext = buildCronDeliveryTargetRuntimeContext({
     resolvedDeliveryOk: params.resolvedDeliveryOk,
     messageToolPromptEnabled: params.messageToolPromptEnabled,
@@ -427,9 +429,7 @@ export function createCronPromptExecutor(params: {
             timeoutMs: params.timeoutMs,
             runId: params.cronSession.sessionEntry.sessionId,
             lane: resolveCronAgentLane(params.lane),
-            // Intentionally-silent cron jobs (watchers that say nothing unless
-            // there is something to report) should not throw empty_response.
-            allowEmptyAssistantReplyAsSilent: true,
+            allowEmptyAssistantReplyAsSilent,
             cliSessionId: cliSessionBinding?.sessionId,
             cliSessionBinding: guardedCliSessionBinding,
             skillsSnapshot: params.skillsSnapshot,
@@ -544,9 +544,7 @@ export function createCronPromptExecutor(params: {
             : undefined,
           sourceReplyDeliveryMode,
           runId: params.cronSession.sessionEntry.sessionId,
-          // Intentionally-silent cron jobs (watchers that say nothing unless
-          // there is something to report) should not throw empty_response.
-          allowEmptyAssistantReplyAsSilent: true,
+          allowEmptyAssistantReplyAsSilent,
           requireExplicitMessageTarget: sourceDelivery.messageTool.requireExplicitTarget,
           disableMessageTool: !sourceDelivery.messageTool.enabled,
           forceMessageTool: sourceDelivery.messageTool.force,
diff --git a/src/cron/isolated-agent/run.message-tool-policy.test.ts b/src/cron/isolated-agent/run.message-tool-policy.test.ts
@@ -755,6 +755,7 @@ describe("runCronIsolatedAgentTurn message tool policy", () => {
     expectRecordFields(
       getMockCallArg(runCliAgentMock, 0, 0, "CLI run"),
       {
+        allowEmptyAssistantReplyAsSilent: true,
         messageChannel: "messagechat",
         requireExplicitMessageTarget: true,
       },
diff --git a/src/cron/isolated-agent/run.source-delivery-guard.test.ts b/src/cron/isolated-agent/run.source-delivery-guard.test.ts
@@ -288,6 +288,7 @@ describe("createCronPromptExecutor sourceDelivery guard", () => {
     expect(runEmbeddedAgentMock).toHaveBeenCalledTimes(1);
     const args = getEmbeddedRunArg();
     expect(args.sourceReplyDeliveryMode).toBeUndefined();
+    expect(args.allowEmptyAssistantReplyAsSilent).toBe(true);
     expect(args.requireExplicitMessageTarget).toBe(false);
     expect(args.disableMessageTool).toBe(false);
     expect(args.forceMessageTool).toBe(false);
@@ -308,6 +309,7 @@ describe("createCronPromptExecutor sourceDelivery guard", () => {
     expect(runEmbeddedAgentMock).toHaveBeenCalledTimes(1);
     const args = getEmbeddedRunArg();
     expect(args.sourceReplyDeliveryMode).toBeUndefined();
+    expect(args.allowEmptyAssistantReplyAsSilent).toBe(true);
     expect(args.disableMessageTool).toBe(false);
     expect(args.forceMessageTool).toBe(false);
     expect(args.messageChannel).toBe("messagechat");

Original file line number	Diff line number	Diff line change
`@@ -755,6 +755,7 @@ describe("runCronIsolatedAgentTurn message tool policy", () => {`
`755`	`755`	`expectRecordFields(`
`756`	`756`	`getMockCallArg(runCliAgentMock, 0, 0, "CLI run"),`
`757`	`757`	`{`
	`758`	`+ allowEmptyAssistantReplyAsSilent: true,`
`758`	`759`	`messageChannel: "messagechat",`
`759`	`760`	`requireExplicitMessageTarget: true,`
`760`	`761`	`},`