fix(ci): clear duplicate declaration and retired-state assertion breaks

steipete · steipete · commit 225638788572 · 2026-07-16T20:37:45.000-07:00
Two direct-landed changes left every PR red: release-candidate-checklist.d.mts declared isDirectReleaseCandidateExecution twice with other declarations between them (adjacent-overload-signatures), and the parallels smoke model test still asserted the workspace-state.json seeding that b6535fb deliberately retired. Drop the duplicate and flip the assertion to guard the retirement.
diff --git a/scripts/release-candidate-checklist.d.mts b/scripts/release-candidate-checklist.d.mts
@@ -98,11 +98,6 @@ export function validateWindowsSourceRelease(
     digest: unknown;
   }[];
 }>;
-export function isDirectReleaseCandidateExecution(
-  directPath: string | undefined,
-  modulePath: string,
-  resolveRealPath?: (path: string) => string,
-): boolean;
 export function validateCandidateCheckout({
   targetSha,
   targetHeadSha,
diff --git a/test/scripts/parallels-smoke-model.test.ts b/test/scripts/parallels-smoke-model.test.ts
@@ -1183,7 +1183,9 @@ if (isPrlctl) {
   it("seeds agent workspace state before OS smoke agent turns", () => {
     const workspace = readFileSync(TS_PATHS.agentWorkspace, "utf8");
 
-    expect(workspace).toContain("workspace-state.json");
+    // workspace-state.json was retired (b6535fb8de5: stop writing retired
+    // smoke state); identity/bootstrap seeding remains the contract.
+    expect(workspace).not.toContain("workspace-state.json");
     expect(workspace).toContain("IDENTITY.md");
     expect(workspace).toContain("BOOTSTRAP.md");
 
