fix(memory): skip empty dreaming placeholders

hyspacex · hyspacex · commit 211d0d14fb47 · 2026-05-11T23:04:34.000-07:00
diff --git a/extensions/memory-core/src/dreaming-phases.test.ts b/extensions/memory-core/src/dreaming-phases.test.ts
@@ -1487,6 +1487,19 @@ describe("memory-core dreaming phases", () => {
     expect(corpus).not.toContain("Run the qmd sync");
   });
 
+  it("omits possible lasting truths section when rem finds no candidate truths", () => {
+    const preview = __testing.previewRemDreaming({
+      entries: [],
+      limit: 5,
+      minPatternStrength: 0,
+    });
+
+    expect(preview.candidateTruths).toStrictEqual([]);
+    expect(preview.bodyLines.join("\n")).toContain("### Reflections");
+    expect(preview.bodyLines.join("\n")).not.toContain("### Possible Lasting Truths");
+    expect(preview.bodyLines.join("\n")).not.toContain("No strong candidate truths surfaced");
+  });
+
   it("ignores chat scaffolding tags when building rem reflections", () => {
     const preview = __testing.previewRemDreaming({
       entries: [
diff --git a/extensions/memory-core/src/dreaming-phases.ts b/extensions/memory-core/src/dreaming-phases.ts
@@ -1532,14 +1532,16 @@ export function previewRemDreaming(params: {
   const bodyLines = [
     "### Reflections",
     ...reflections,
-    "",
-    "### Possible Lasting Truths",
     ...(candidateTruths.length > 0
-      ? candidateTruths.map(
-          (entry) =>
-            `- ${entry.snippet} [confidence=${entry.confidence.toFixed(2)} evidence=${entry.evidence}]`,
-        )
-      : ["- No strong candidate truths surfaced."]),
+      ? [
+          "",
+          "### Possible Lasting Truths",
+          ...candidateTruths.map(
+            (entry) =>
+              `- ${entry.snippet} [confidence=${entry.confidence.toFixed(2)} evidence=${entry.evidence}]`,
+          ),
+        ]
+      : []),
   ];
   return {
     sourceEntryCount: params.entries.length,
diff --git a/extensions/memory-core/src/short-term-promotion.test.ts b/extensions/memory-core/src/short-term-promotion.test.ts
@@ -1110,6 +1110,17 @@ describe("short-term promotion", () => {
     ).toBe(false);
   });
 
+  it("treats empty rem candidate placeholders as contaminated", () => {
+    expect(
+      __testing.isEmptyDreamingCandidatePlaceholder("- No strong candidate truths surfaced."),
+    ).toBe(true);
+    expect(
+      __testing.isContaminatedDreamingSnippet(
+        "- Candidate: Possible Lasting Truths: No strong candidate truths surfaced.",
+      ),
+    ).toBe(true);
+  });
+
   it("treats transcript-style dreaming prompt echoes as contaminated", () => {
     expect(
       __testing.isContaminatedDreamingSnippet(
@@ -1118,6 +1129,48 @@ describe("short-term promotion", () => {
     ).toBe(true);
   });
 
+  it("skips empty rem candidate placeholders during apply", async () => {
+    await withTempWorkspace(async (workspaceDir) => {
+      const applied = await applyShortTermPromotions({
+        workspaceDir,
+        minScore: 0,
+        minRecallCount: 0,
+        minUniqueQueries: 0,
+        candidates: [
+          {
+            key: "memory:memory/2026-04-08.md:13:13",
+            path: "memory/2026-04-08.md",
+            startLine: 13,
+            endLine: 13,
+            source: "memory",
+            snippet: "- Candidate: Possible Lasting Truths: No strong candidate truths surfaced.",
+            recallCount: 3,
+            avgScore: 0.95,
+            maxScore: 0.95,
+            uniqueQueries: 2,
+            firstRecalledAt: "2026-04-08T00:00:00.000Z",
+            lastRecalledAt: "2026-04-09T00:00:00.000Z",
+            ageDays: 0,
+            score: 0.95,
+            recallDays: ["2026-04-08", "2026-04-09"],
+            conceptTags: ["candidate", "truths"],
+            components: {
+              frequency: 1,
+              relevance: 1,
+              diversity: 1,
+              recency: 1,
+              consolidation: 1,
+              conceptual: 1,
+            },
+          },
+        ],
+      });
+
+      expect(applied.applied).toBe(0);
+      await expectEnoent(fs.readFile(path.join(workspaceDir, "MEMORY.md"), "utf-8"));
+    });
+  });
+
   it("skips direct candidates that exceed maxAgeDays during apply", async () => {
     await withTempWorkspace(async (workspaceDir) => {
       const applied = await applyShortTermPromotions({
diff --git a/extensions/memory-core/src/short-term-promotion.ts b/extensions/memory-core/src/short-term-promotion.ts
@@ -287,14 +287,27 @@ function hasDreamingNarrativeLead(snippet: string): boolean {
   return /^Candidate:/i.test(withoutPrefix) || /^Reflections?:/i.test(withoutPrefix);
 }
 
+function isEmptyDreamingCandidatePlaceholder(raw: string): boolean {
+  const snippet = normalizeSnippet(raw);
+  if (!snippet) {
+    return false;
+  }
+  const withoutPrefix = consumeDreamingLeadPrefix(snippet)
+    .replace(/^Candidate:\s*/i, "")
+    .replace(/^Possible Lasting Truths:\s*/i, "")
+    .trim();
+  return /^No strong candidate truths surfaced\.?$/i.test(withoutPrefix);
+}
+
 function isContaminatedDreamingSnippet(raw: string): boolean {
   const snippet = normalizeSnippet(raw);
   if (!snippet) {
     return false;
   }
   if (
     /<!--\s*openclaw-memory-promotion:/i.test(snippet) ||
-    DREAMING_TRANSCRIPT_PROMPT_LINE_RE.test(snippet)
+    DREAMING_TRANSCRIPT_PROMPT_LINE_RE.test(snippet) ||
+    isEmptyDreamingCandidatePlaceholder(snippet)
   ) {
     return true;
   }
@@ -2018,4 +2031,5 @@ export const __testing = {
   buildClaimHash,
   totalSignalCountForEntry,
   isContaminatedDreamingSnippet,
+  isEmptyDreamingCandidatePlaceholder,
 };
