fix(agents): extend send-loop volatility strip to provider-docked tools

openperf · openperf · commit 1f4246e34e0e · 2026-06-05T14:05:39.000+08:00
diff --git a/src/agents/tool-loop-detection.test.ts b/src/agents/tool-loop-detection.test.ts
@@ -1,8 +1,18 @@
 // Tool loop detection tests cover repeated-call hashing, ping-pong detection,
 // unknown-tool thresholds, and circuit-breaker escalation.
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, vi } from "vitest";
 import type { ToolLoopDetectionConfig } from "../config/types.tools.js";
 import type { SessionState } from "../logging/diagnostic-session-state.js";
+
+// Recognize a provider-docked send tool by name (only "telegram" here) so the
+// volatility strip applies to it without pulling in the channel-plugin registry; the
+// real detector is covered by embedded-agent-messaging's own tests.
+const isMessagingToolSendActionMock = vi.hoisted(() =>
+  vi.fn((toolName: string): boolean => toolName === "telegram"),
+);
+vi.mock("./embedded-agent-messaging.js", () => ({
+  isMessagingToolSendAction: isMessagingToolSendActionMock,
+}));
 import {
   CRITICAL_THRESHOLD,
   GLOBAL_CIRCUIT_BREAKER_THRESHOLD,
@@ -1013,6 +1023,19 @@ describe("tool-loop-detection", () => {
       }
     });
 
+    it("escalates provider-docked send-tool loops (e.g. telegram) whose result carries fresh ids", () => {
+      const state = createState();
+      const params = { to: "telegram:123", text: "ping" };
+      for (let i = 0; i < CRITICAL_THRESHOLD; i += 1) {
+        recordSend(state, "telegram", params, sendPayload(i), i);
+      }
+      const loopResult = detectToolCallLoop(state, "telegram", params, enabledLoopDetectionConfig);
+      expect(loopResult.stuck).toBe(true);
+      if (loopResult.stuck) {
+        expect(loopResult.level).toBe("critical");
+      }
+    });
+
     it("escalates sibling delivery actions (reply) the same as send", () => {
       const state = createState();
       const params = { action: "reply", target: "feishu:oc_chat", text: "ping" };
diff --git a/src/agents/tool-loop-detection.ts b/src/agents/tool-loop-detection.ts
@@ -12,6 +12,7 @@ import type { ToolLoopDetectionConfig } from "../config/types.tools.js";
 import type { SessionState, ToolCallRecord } from "../logging/diagnostic-session-state.js";
 import { createSubsystemLogger } from "../logging/subsystem.js";
 import { isPlainObject } from "../utils.js";
+import { isMessagingToolSendAction } from "./embedded-agent-messaging.js";
 import { stableStringify } from "./stable-stringify.js";
 
 const log = createSubsystemLogger("agents/loop-detection");
@@ -245,10 +246,15 @@ const SEND_LIKE_MESSAGE_ACTIONS = new Set([
   "sticker",
   "poll",
 ]);
+// Denylist of per-call volatile delivery ids/timestamps stripped before hashing. Must
+// cover the id/timestamp fields a channel's delivery result can carry; a new channel
+// emitting a volatile field name outside this set silently regresses its loop blocking.
 const VOLATILE_SEND_RESULT_KEYS = new Set([
   "messageId",
   "message_id",
   "messageIds",
+  "platformMessageId",
+  "platformMessageIds",
   "fileId",
   "file_id",
   "fileKey",
@@ -299,10 +305,14 @@ function isVolatileSendResult(toolName: string, params: unknown): boolean {
   if (toolName === "sessions_send") {
     return true;
   }
-  if (toolName !== "message" || !isPlainObject(params)) {
-    return false;
+  const args = isPlainObject(params) ? params : {};
+  if (toolName === "message") {
+    return typeof args.action === "string" && SEND_LIKE_MESSAGE_ACTIONS.has(args.action);
   }
-  return typeof params.action === "string" && SEND_LIKE_MESSAGE_ACTIONS.has(params.action);
+  // Provider-docked send tools (telegram/discord/...) return the same volatile-id shape.
+  // SEND_LIKE_MESSAGE_ACTIONS stays broader than the terminal-send set on purpose:
+  // broadcast/reply/sticker/poll carry volatile ids but are not terminal sends.
+  return isMessagingToolSendAction(toolName, args);
 }
 
 // Only the loop detector's own veto must not reset the streak; other blocked results
