test(macos): remove Swift warning and timing flake (#104434)

steipete · web-flow · commit 1d84acf2c35b · 2026-07-11T04:30:35.000-07:00
diff --git a/apps/macos/Tests/OpenClawIPCTests/ExecApprovalsSocketPathGuardTests.swift b/apps/macos/Tests/OpenClawIPCTests/ExecApprovalsSocketPathGuardTests.swift
@@ -170,7 +170,7 @@ struct ExecApprovalsSocketPathGuardTests {
         // old filesystem assertions here flaked on their 0755 default
         // (#104019). Creation-with-0700 is covered by the explicit-path
         // tests in this suite.
-        try await TestIsolation.withEnvValues(["OPENCLAW_STATE_DIR": stateDir.path]) {
+        await TestIsolation.withEnvValues(["OPENCLAW_STATE_DIR": stateDir.path]) {
             let socketPath = ExecApprovalsStore.socketPath()
             #expect(socketPath == stateDir.appendingPathComponent("exec-approvals.sock").path)
         }
diff --git a/apps/macos/Tests/OpenClawIPCTests/ExecApprovalsStoreRefactorTests.swift b/apps/macos/Tests/OpenClawIPCTests/ExecApprovalsStoreRefactorTests.swift
@@ -2242,19 +2242,16 @@ extension ExecApprovalsStoreRefactorTests {
                 [.modificationDate: Date().addingTimeInterval(-31)],
                 ofItemAtPath: lockURL.path)
 
-            let startedAt = Date()
             let result = ExecApprovalsStore.addAllowlistEntry(
                 agentId: "main",
                 pattern: "/bin/echo")
-            let elapsed = Date().timeIntervalSince(startedAt)
 
             guard case .failure(.unavailable) = result else {
                 Issue.record("expected lock contention failure")
                 return
             }
             #expect(FileManager().fileExists(atPath: lockURL.path))
             #expect(try Data(contentsOf: lockURL) == Data("{".utf8))
-            #expect(elapsed < 0.5)
             #expect(ExecApprovalsStore.loadFile().agents?["main"]?.allowlist?.isEmpty != false)
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ struct ExecApprovalsSocketPathGuardTests {`
`170`	`170`	`// old filesystem assertions here flaked on their 0755 default`
`171`	`171`	`// (#104019). Creation-with-0700 is covered by the explicit-path`
`172`	`172`	`// tests in this suite.`
`173`		`- try await TestIsolation.withEnvValues(["OPENCLAW_STATE_DIR": stateDir.path]) {`
	`173`	`+ await TestIsolation.withEnvValues(["OPENCLAW_STATE_DIR": stateDir.path]) {`
`174`	`174`	`let socketPath = ExecApprovalsStore.socketPath()`
`175`	`175`	`#expect(socketPath == stateDir.appendingPathComponent("exec-approvals.sock").path)`
`176`	`176`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2242,19 +2242,16 @@ extension ExecApprovalsStoreRefactorTests {`
`2242`	`2242`	`[.modificationDate: Date().addingTimeInterval(-31)],`
`2243`	`2243`	`ofItemAtPath: lockURL.path)`
`2244`	`2244`
`2245`		`- let startedAt = Date()`
`2246`	`2245`	`let result = ExecApprovalsStore.addAllowlistEntry(`
`2247`	`2246`	`agentId: "main",`
`2248`	`2247`	`pattern: "/bin/echo")`
`2249`		`- let elapsed = Date().timeIntervalSince(startedAt)`
`2250`	`2248`
`2251`	`2249`	`guard case .failure(.unavailable) = result else {`
`2252`	`2250`	`Issue.record("expected lock contention failure")`
`2253`	`2251`	`return`
`2254`	`2252`	`}`
`2255`	`2253`	`#expect(FileManager().fileExists(atPath: lockURL.path))`
`2256`	`2254`	`#expect(try Data(contentsOf: lockURL) == Data("{".utf8))`
`2257`		`- #expect(elapsed < 0.5)`
`2258`	`2255`	`#expect(ExecApprovalsStore.loadFile().agents?["main"]?.allowlist?.isEmpty != false)`
`2259`	`2256`	`}`
`2260`	`2257`	`}`