fix: add retry logic for Windows EPERM errors in atomic file writes

nick8799981325 · nick8799981325 · commit 1d7c775d92fa · 2026-03-31T14:21:47.000+08:00
diff --git a/src/infra/json-files.ts b/src/infra/json-files.ts
@@ -1,6 +1,11 @@
 import { randomUUID } from "node:crypto";
 import fs from "node:fs/promises";
 import path from "node:path";
+import { setTimeout as sleep } from "node:timers/promises";
+
+const MAX_RETRIES = 5;
+const RETRY_BASE_DELAY_MS = 50;
+const IS_WINDOWS = process.platform === "win32";
 
 export async function readJsonFile<T>(filePath: string): Promise<T | null> {
   try {
@@ -36,40 +41,58 @@ export async function writeTextAtomic(
   if (typeof options?.ensureDirMode === "number") {
     mkdirOptions.mode = options.ensureDirMode;
   }
-  await fs.mkdir(path.dirname(filePath), mkdirOptions);
   const parentDir = path.dirname(filePath);
-  const tmp = `${filePath}.${randomUUID()}.tmp`;
-  try {
-    const tmpHandle = await fs.open(tmp, "w", mode);
-    try {
-      await tmpHandle.writeFile(payload, { encoding: "utf8" });
-      await tmpHandle.sync();
-    } finally {
-      await tmpHandle.close().catch(() => undefined);
-    }
+  for (let attempt = 1; attempt <= MAX_RETRIES + 1; attempt++) {
+    await fs.mkdir(parentDir, mkdirOptions);
+    const tmp = `${filePath}.${randomUUID()}.tmp`;
     try {
-      await fs.chmod(tmp, mode);
-    } catch {
-      // best-effort; ignore on platforms without chmod
-    }
-    await fs.rename(tmp, filePath);
-    try {
-      const dirHandle = await fs.open(parentDir, "r");
+      const tmpHandle = await fs.open(tmp, "w", mode);
       try {
-        await dirHandle.sync();
+        await tmpHandle.writeFile(payload, { encoding: "utf8" });
+        await tmpHandle.sync();
       } finally {
-        await dirHandle.close().catch(() => undefined);
+        await tmpHandle.close().catch(() => undefined);
       }
-    } catch {
-      // best-effort; some platforms/filesystems do not support syncing directories.
-    }
-    try {
-      await fs.chmod(filePath, mode);
-    } catch {
-      // best-effort; ignore on platforms without chmod
+      try {
+        await fs.chmod(tmp, mode);
+      } catch {
+        // best-effort; ignore on platforms without chmod
+      }
+      await fs.rename(tmp, filePath);
+      try {
+        const dirHandle = await fs.open(parentDir, "r");
+        try {
+          await dirHandle.sync();
+        } finally {
+          await dirHandle.close().catch(() => undefined);
+        }
+      } catch {
+        // best-effort; some platforms/filesystems do not support syncing directories.
+      }
+      try {
+        await fs.chmod(filePath, mode);
+      } catch {
+        // best-effort; ignore on platforms without chmod
+      }
+      return;
+    } catch (err) {
+      // Only retry on Windows; other platforms should fail fast
+      if (
+        IS_WINDOWS &&
+        err &&
+        typeof err === "object" &&
+        "code" in err &&
+        err.code === "EPERM" &&
+        attempt < MAX_RETRIES + 1
+      ) {
+        const delay = 2 ** attempt * RETRY_BASE_DELAY_MS;
+        await sleep(delay);
+        continue;
+      }
+      throw err;
+    } finally {
+      await fs.rm(tmp, { force: true }).catch(() => undefined);
     }
-  } finally {
-    await fs.rm(tmp, { force: true }).catch(() => undefined);
   }
 }
 
