Fix: Respect plugin defaultChoice for stable/beta channels

Agent F46B0548A3AA · claude · Agent F46B0548A3AA · commit 1c2cb94b8aaa · 2026-02-05T00:53:11.000Z
Addressed Greptile review feedback: The previous logic forced "npm" for
stable/beta update channels, ignoring the plugin's defaultChoice. This
caused 404 errors for unpublished plugins even after setting defaultChoice
to "local" in their package.json.

Now stable/beta channels respect the plugin's defaultChoice setting:
- If defaultChoice is "local", use bundled version (if available)
- Otherwise default to "npm" (existing behavior for published plugins)

This ensures unpublished plugins (googlechat, mattermost, line, tlon)
work correctly during setup regardless of the user's update channel.

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/src/commands/onboarding/plugin-install.ts b/src/commands/onboarding/plugin-install.ts
@@ -109,13 +109,21 @@ function resolveInstallDefaultChoice(params: {
 }): InstallChoice {
   const { cfg, entry, localPath } = params;
   const updateChannel = cfg.update?.channel;
-  if (updateChannel === "dev") {
-    return localPath ? "local" : "npm";
-  }
+  const entryDefault = entry.install.defaultChoice;
+
+  // For stable/beta channels, respect the plugin's defaultChoice
+  // This allows unpublished plugins to default to "local"
   if (updateChannel === "stable" || updateChannel === "beta") {
+    if (entryDefault === "local") {
+      return localPath ? "local" : "npm";
+    }
     return "npm";
   }
-  const entryDefault = entry.install.defaultChoice;
+
+  if (updateChannel === "dev") {
+    return localPath ? "local" : "npm";
+  }
+
   if (entryDefault === "local") {
     return localPath ? "local" : "npm";
   }
