refactor: trim channel contract test helpers

steipete · steipete · commit 1a796b9700ae · 2026-05-02T04:39:56.000+01:00
diff --git a/src/channels/plugins/contracts/test-helpers/bundled-channel-plugin-loader.ts b/src/channels/plugins/contracts/test-helpers/bundled-channel-plugin-loader.ts
@@ -85,10 +85,3 @@ export function listBundledChannelPlugins(): readonly ChannelPlugin[] {
     return plugin ? [plugin] : [];
   });
 }
-
-export async function listBundledChannelPluginsAsync(): Promise<readonly ChannelPlugin[]> {
-  const plugins = await Promise.all(
-    listBundledChannelPluginIds().map((id) => getBundledChannelPluginAsync(id)),
-  );
-  return plugins.filter((plugin): plugin is ChannelPlugin => Boolean(plugin));
-}
diff --git a/src/channels/plugins/contracts/test-helpers/group-policy-contract-suites.ts b/src/channels/plugins/contracts/test-helpers/group-policy-contract-suites.ts
@@ -1,8 +1,6 @@
 import { expect, it } from "vitest";
 import { resolveOpenProviderRuntimeGroupPolicy } from "../../../../config/runtime-group-policy.js";
 
-type ResolvedGroupPolicy = ReturnType<typeof resolveOpenProviderRuntimeGroupPolicy>;
-
 export type RuntimeGroupPolicyResolver = (
   params: Parameters<typeof resolveOpenProviderRuntimeGroupPolicy>[0],
 ) => ReturnType<typeof resolveOpenProviderRuntimeGroupPolicy>;
@@ -39,11 +37,3 @@ export function installChannelRuntimeGroupPolicyFallbackSuite(params: {
     expect(resolved.providerMissingFallbackApplied).toBe(true);
   });
 }
-
-export function expectResolvedGroupPolicyCase(
-  resolved: Pick<ResolvedGroupPolicy, "groupPolicy" | "providerMissingFallbackApplied">,
-  expected: Pick<ResolvedGroupPolicy, "groupPolicy" | "providerMissingFallbackApplied">,
-) {
-  expect(resolved.groupPolicy).toBe(expected.groupPolicy);
-  expect(resolved.providerMissingFallbackApplied).toBe(expected.providerMissingFallbackApplied);
-}
diff --git a/src/channels/plugins/contracts/test-helpers/registry-plugin.ts b/src/channels/plugins/contracts/test-helpers/registry-plugin.ts
@@ -1,33 +1,10 @@
 import type { ChannelId } from "../../channel-id.types.js";
-import { normalizeChannelMeta } from "../../meta-normalization.js";
-import type { ChannelPlugin } from "../../types.js";
-import {
-  getBundledChannelCatalogEntry,
-  getBundledChannelPlugin,
-  listBundledChannelPluginIds,
-  listBundledChannelPlugins,
-} from "./bundled-channel-plugin-loader.js";
-
-type PluginContractEntry = {
-  id: string;
-  plugin: Pick<ChannelPlugin, "id" | "meta" | "capabilities" | "config">;
-};
+import { listBundledChannelPluginIds } from "./bundled-channel-plugin-loader.js";
 
 type PluginContractRef = {
   id: ChannelId;
 };
 
-function toPluginContractEntry(plugin: ChannelPlugin): PluginContractEntry {
-  const existingMeta = getBundledChannelCatalogEntry(plugin.id)?.channel;
-  return {
-    id: plugin.id,
-    plugin: {
-      ...plugin,
-      meta: normalizeChannelMeta({ id: plugin.id, meta: plugin.meta, existing: existingMeta }),
-    },
-  };
-}
-
 function getBundledChannelPluginIdsForShard(params: {
   shardIndex: number;
   shardCount: number;
@@ -37,20 +14,6 @@ function getBundledChannelPluginIdsForShard(params: {
   );
 }
 
-export function getPluginContractRegistry(): PluginContractEntry[] {
-  return listBundledChannelPlugins().map(toPluginContractEntry);
-}
-
-export function getPluginContractRegistryShard(params: {
-  shardIndex: number;
-  shardCount: number;
-}): PluginContractEntry[] {
-  return getBundledChannelPluginIdsForShard(params).flatMap((id) => {
-    const plugin = getBundledChannelPlugin(id);
-    return plugin ? [toPluginContractEntry(plugin)] : [];
-  });
-}
-
 export function getPluginContractRegistryShardRefs(params: {
   shardIndex: number;
   shardCount: number;
