fix(googlechat): throw on non-ok response instead of parsing error body as success

ajwan8998 · ajwan8998 · commit 199ab99f63e8 · 2026-06-25T10:54:24.000+08:00
When the Google Chat API returns 4xx/5xx with a JSON error body,
response.json() parses the error as the success type T, hiding
the HTTP status code and error message. The caller sees a
type-valid success response where expected fields are undefined.

Add response.ok check before response.json() so HTTP errors throw
with status code and response body. Export readGoogleChatJsonResponse
for reuse.
diff --git a/extensions/googlechat/src/api.ts b/extensions/googlechat/src/api.ts
@@ -12,7 +12,7 @@ import type { GoogleChatCardV2, GoogleChatReaction } from "./types.js";
 const CHAT_API_BASE = "https://chat.googleapis.com/v1";
 const CHAT_UPLOAD_BASE = "https://chat.googleapis.com/upload/v1";
 
-async function readGoogleChatJsonResponse<T>(response: Response, label: string): Promise<T> {
+export async function readGoogleChatJsonResponse<T>(response: Response, label: string): Promise<T> {
   if (!response.ok) {
     const body = await response.text().catch(() => "");
     throw new Error(`${label}: HTTP ${response.status}${body ? ` — ${body.slice(0, 200)}` : ""}`);
