fix(lint): clean up main lint regressions

vincentkoc · vincentkoc · commit 1831e124b221 · 2026-05-07T01:39:46.000-07:00
diff --git a/extensions/canvas/src/cli.ts b/extensions/canvas/src/cli.ts
@@ -102,15 +102,23 @@ function parseNodeCandidates(raw: unknown): CanvasNodeCandidate[] {
         connected?: unknown;
         clientId?: unknown;
       };
-      return typeof node.nodeId === "string"
-        ? {
-            nodeId: node.nodeId,
-            ...(typeof node.displayName === "string" && { displayName: node.displayName }),
-            ...(typeof node.remoteIp === "string" && { remoteIp: node.remoteIp }),
-            ...(typeof node.connected === "boolean" && { connected: node.connected }),
-            ...(typeof node.clientId === "string" && { clientId: node.clientId }),
-          }
-        : null;
+      if (typeof node.nodeId !== "string") {
+        return null;
+      }
+      const candidate: CanvasNodeCandidate = { nodeId: node.nodeId };
+      if (typeof node.displayName === "string") {
+        candidate.displayName = node.displayName;
+      }
+      if (typeof node.remoteIp === "string") {
+        candidate.remoteIp = node.remoteIp;
+      }
+      if (typeof node.connected === "boolean") {
+        candidate.connected = node.connected;
+      }
+      if (typeof node.clientId === "string") {
+        candidate.clientId = node.clientId;
+      }
+      return candidate;
     })
     .filter((entry): entry is CanvasNodeCandidate => entry !== null);
 }
diff --git a/extensions/canvas/src/config-migration.ts b/extensions/canvas/src/config-migration.ts
@@ -11,10 +11,7 @@ function mergeHostConfig(params: {
   legacyHost: MutableRecord;
   existingHost: MutableRecord | undefined;
 }): MutableRecord {
-  return {
-    ...params.legacyHost,
-    ...(params.existingHost ?? {}),
-  };
+  return Object.assign({}, params.legacyHost, params.existingHost);
 }
 
 export function migrateLegacyCanvasHostConfig(config: OpenClawConfig): {
diff --git a/extensions/canvas/src/config.ts b/extensions/canvas/src/config.ts
@@ -59,9 +59,7 @@ export function parseCanvasPluginConfig(value: unknown): CanvasPluginConfig {
     return {};
   }
   const host = parseCanvasHostConfig(value.host);
-  return {
-    ...(host ? { host } : {}),
-  };
+  return host ? { host } : {};
 }
 
 export function isCanvasPluginEnabled(config?: OpenClawConfig): boolean {
diff --git a/src/gateway/server-http.ts b/src/gateway/server-http.ts
@@ -497,7 +497,6 @@ export function createGatewayHttpServer(opts: {
     strictTransportSecurityHeader,
     handleHooksRequest,
     handlePluginRequest,
-    handlePluginUpgrade,
     shouldEnforcePluginGatewayAuth,
     resolvePluginNodeCapabilityRoute,
     resolvedAuth,
diff --git a/src/gateway/server.models-voicewake-misc.test.ts b/src/gateway/server.models-voicewake-misc.test.ts
@@ -23,8 +23,6 @@ import {
   startConnectedServerWithClient,
   startGatewayServer,
   startServerWithClient,
-  testState,
-  testTailnetIPv4,
   trackConnectChallengeNonce,
 } from "./test-helpers.js";
 
diff --git a/src/gateway/server/plugins-http/route-capability.ts b/src/gateway/server/plugins-http/route-capability.ts
@@ -34,10 +34,11 @@ export function findMatchingPluginNodeCapabilityRoutes(
 ): PluginNodeCapabilityRoute[] {
   return findMatchingPluginHttpRoutes(registry, context)
     .filter(hasNodeCapabilityRoute)
-    .map((route) => ({
-      ...route,
-      nodeCapability: resolvePluginNodeCapabilityRouteSurface(route),
-    }));
+    .map((route) =>
+      Object.assign({}, route, {
+        nodeCapability: resolvePluginNodeCapabilityRouteSurface(route),
+      }),
+    );
 }
 
 export function findMatchingPluginNodeCapabilityRoute(
diff --git a/src/plugins/registry.ts b/src/plugins/registry.ts
@@ -1293,18 +1293,17 @@ export function createPluginRegistry(registryParams: PluginRegistryParams) {
     }
     const serializeCommandPath = (command: string) => [...normalizedParentPath, command].join(" ");
     const commandPaths = commands.map(serializeCommandPath);
+    const commandPathSet = new Set(commandPaths);
     const existing = registry.cliRegistrars.find((entry) =>
       entry.commands
         .map((command) => [...(entry.parentPath ?? []), command].join(" "))
-        .some((commandPath) => commandPaths.includes(commandPath)),
+        .some((commandPath) => commandPathSet.has(commandPath)),
     );
     if (existing) {
-      const existingCommandPaths = existing.commands.map((command) =>
-        [...(existing.parentPath ?? []), command].join(" "),
-      );
-      const overlap = commandPaths.find((commandPath) =>
-        existingCommandPaths.includes(commandPath),
+      const existingCommandPaths = new Set(
+        existing.commands.map((command) => [...(existing.parentPath ?? []), command].join(" ")),
       );
+      const overlap = commandPaths.find((commandPath) => existingCommandPaths.has(commandPath));
       pushDiagnostic({
         level: "error",
         pluginId: record.id,

Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,7 @@ export function parseCanvasPluginConfig(value: unknown): CanvasPluginConfig {`
`59`	`59`	`return {};`
`60`	`60`	`}`
`61`	`61`	`const host = parseCanvasHostConfig(value.host);`
`62`		`- return {`
`63`		`- ...(host ? { host } : {}),`
`64`		`- };`
	`62`	`+ return host ? { host } : {};`
`65`	`63`	`}`
`66`	`64`
`67`	`65`	`export function isCanvasPluginEnabled(config?: OpenClawConfig): boolean {`